Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 12052008: Allow loading constant function from proto chain. (Closed)

Created:
7 years, 11 months ago by Michael Starzinger
Modified:
7 years, 11 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Allow loading constant function from proto chain. This enables Crankshaft to use HConstant for loading constant functions on the prototype chain when building a monomorphic load. This pattern appears in several JavaScript frameworks. R=svenpanne@chromium.org TEST=mjsunit/compiler/proto-chain-constant Committed: http://code.google.com/p/v8/source/detail?r=13463

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -12 lines) Patch
M src/hydrogen.cc View 2 chunks +12 lines, -1 line 0 comments Download
A + test/mjsunit/compiler/proto-chain-constant.js View 2 chunks +22 lines, -11 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Michael Starzinger
7 years, 11 months ago (2013-01-22 10:46:36 UTC) #1
Sven Panne
7 years, 11 months ago (2013-01-22 11:21:30 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698