Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7345)

Unified Diff: chrome/test/chromedriver/commands_unittest.cc

Issue 12052004: [chromedriver] Create release script and handle Chrome/ChromeDriver versions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/commands_unittest.cc
diff --git a/chrome/test/chromedriver/commands_unittest.cc b/chrome/test/chromedriver/commands_unittest.cc
index b85e5d7396e3563ad9d03f5c598d5617df0fd6e9..bc88cf2960811beb28dd137e5f484531061a1cdc 100644
--- a/chrome/test/chromedriver/commands_unittest.cc
+++ b/chrome/test/chromedriver/commands_unittest.cc
@@ -56,6 +56,20 @@ class StubChrome : public Chrome {
}
};
+class OkChrome : public StubChrome {
+ public:
+ OkChrome() {}
+ virtual ~OkChrome() {}
+
+ // Overridden from StubChrome:
+ virtual Status EvaluateScript(const std::string& frame,
+ const std::string& function,
+ scoped_ptr<base::Value>* result) OVERRIDE {
+ result->reset(base::Value::CreateStringValue("99.0.99999.0"));
+ return Status(kOk);
+ }
+};
+
class OkLauncher : public ChromeLauncher {
public:
OkLauncher() {}
@@ -64,7 +78,7 @@ class OkLauncher : public ChromeLauncher {
// Overridden from ChromeLauncher:
virtual Status Launch(const FilePath& chrome_exe,
scoped_ptr<Chrome>* chrome) OVERRIDE {
- chrome->reset(new StubChrome());
+ chrome->reset(new OkChrome());
return Status(kOk);
}
};

Powered by Google App Engine
This is Rietveld 408576698