Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Issue 12052004: [chromedriver] Create release script and handle Chrome/ChromeDriver versions. (Closed)

Created:
7 years, 11 months ago by kkania
Modified:
7 years, 9 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

[chromedriver] Upload builds and handle Chrome/ChromeDriver versions. This adds run_buildbot_steps.py, which will be called by buildbot instead of run_all_tests.py. The new script invokes run_all_tests.py and uploads the ChromeDriver binary to googlecode if it's a unreleased version and if all the tests pass. Thus, to release ChromeDriver, all that is needed is to increment the ChromeDriver version. Also, don't allow ChromeDriver to control an incompatible Chrome version. As part of getting the Chrome version, fix ChromeImpl::EvaluateScript to return the pure script result and not expect a {status:, value:} like ChromeImpl::CallFunction should. BUG=169087 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178394

Patch Set 1 : . #

Total comments: 6

Patch Set 2 : address comments #

Patch Set 3 : rebase #

Patch Set 4 : . #

Patch Set 5 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+523 lines, -31 lines) Patch
M chrome/chrome_tests.gypi View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/chromedriver/chrome_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/chromedriver/chrome_impl.cc View 1 2 2 chunks +31 lines, -14 lines 0 comments Download
M chrome/test/chromedriver/chrome_impl_unittest.cc View 1 2 3 chunks +29 lines, -17 lines 0 comments Download
M chrome/test/chromedriver/commands.cc View 1 2 4 chunks +31 lines, -0 lines 0 comments Download
M chrome/test/chromedriver/commands_unittest.cc View 1 2 2 chunks +15 lines, -1 line 0 comments Download
A chrome/test/chromedriver/run_buildbot_steps.py View 1 chunk +96 lines, -0 lines 0 comments Download
A + chrome/test/chromedriver/third_party/googlecode/LICENSE View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/test/chromedriver/third_party/googlecode/README.chromium View 1 chunk +14 lines, -0 lines 0 comments Download
A chrome/test/chromedriver/third_party/googlecode/googlecode_upload.py View 1 chunk +262 lines, -0 lines 0 comments Download
A chrome/test/chromedriver/version.h View 1 chunk +15 lines, -0 lines 0 comments Download
A chrome/test/chromedriver/version.cc View 1 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kkania
7 years, 11 months ago (2013-01-22 02:17:49 UTC) #1
craigdh
lgtm.
7 years, 11 months ago (2013-01-22 17:44:17 UTC) #2
chrisgao (Use stgao instead)
lgtm lgtm with minor suggestion. https://codereview.chromium.org/12052004/diff/2001/chrome/test/chromedriver/chrome_impl.cc File chrome/test/chromedriver/chrome_impl.cc (right): https://codereview.chromium.org/12052004/diff/2001/chrome/test/chromedriver/chrome_impl.cc#newcode136 chrome/test/chromedriver/chrome_impl.cc:136: return internal::ParseCallFunctionResult(*temp_result.get(), result); I ...
7 years, 11 months ago (2013-01-22 19:17:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkania@chromium.org/12052004/8001
7 years, 11 months ago (2013-01-23 18:43:12 UTC) #4
kkania
7 years, 9 months ago (2013-02-28 21:50:17 UTC) #5
Message was sent while issue was closed.
https://codereview.chromium.org/12052004/diff/2001/chrome/test/chromedriver/c...
File chrome/test/chromedriver/chrome_impl.cc (right):

https://codereview.chromium.org/12052004/diff/2001/chrome/test/chromedriver/c...
chrome/test/chromedriver/chrome_impl.cc:136: return
internal::ParseCallFunctionResult(*temp_result.get(), result);
On 2013/01/22 19:17:31, Shuotao Gao wrote:
> I think "*temp_result" would also work here.

Done.

https://codereview.chromium.org/12052004/diff/2001/chrome/test/chromedriver/v...
File chrome/test/chromedriver/version.cc (right):

https://codereview.chromium.org/12052004/diff/2001/chrome/test/chromedriver/v...
chrome/test/chromedriver/version.cc:20: std::string GetChromeDriverVersion() {
On 2013/01/22 19:17:31, Shuotao Gao wrote:
> This function is not declared in version.h

Whoops, i forgot to delete this when i changed kChromeDriverVersion from an
int[2] to string. Deleted

https://codereview.chromium.org/12052004/diff/2001/chrome/test/chromedriver/v...
chrome/test/chromedriver/version.cc:24: kChromeDriverVersion[1]);
On 2013/01/22 19:17:31, Shuotao Gao wrote:
> kChromeDriverVersion[2]

Removed this func

Powered by Google App Engine
This is Rietveld 408576698