Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(697)

Issue 1205193002: Fix enable_topchrome_md define misspelling. (Closed)

Created:
5 years, 6 months ago by Dan Beam
Modified:
5 years, 6 months ago
CC:
chromium-reviews, bruthig, tdanderson
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix enable_topchrome_md define misspelling. R=girard@chromium.org BUG=none TEST=GN build works? Committed: https://crrev.com/b6974eabfd57abde66d3b84182f7e2b8926685c7 Cr-Commit-Position: refs/heads/master@{#336060}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/config/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (5 generated)
Dan Beam
5 years, 6 months ago (2015-06-24 22:34:28 UTC) #1
Dan Beam
+bruthig, tdanderson as FYI
5 years, 6 months ago (2015-06-24 22:35:10 UTC) #2
tdanderson
lgtm
5 years, 6 months ago (2015-06-24 23:13:05 UTC) #4
Dirk Pranke
lgtm
5 years, 6 months ago (2015-06-24 23:15:19 UTC) #6
scottmg
lgtm
5 years, 6 months ago (2015-06-24 23:15:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1205193002/1
5 years, 6 months ago (2015-06-24 23:17:11 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-25 01:11:02 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b6974eabfd57abde66d3b84182f7e2b8926685c7 Cr-Commit-Position: refs/heads/master@{#336060}
5 years, 6 months ago (2015-06-25 01:12:01 UTC) #12
Nico
lgtm First!
5 years, 6 months ago (2015-06-25 15:57:10 UTC) #14
girard
5 years, 6 months ago (2015-06-25 19:33:04 UTC) #15
Message was sent while issue was closed.
On 2015/06/25 15:57:10, Nico wrote:
> lgtm
> 
> First!

Ahh, the joy of checking in code that doesn't actually do anything yet;)

lgtm

Powered by Google App Engine
This is Rietveld 408576698