Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Unified Diff: Source/core/paint/BlockPainter.cpp

Issue 1205143003: Remove diagnostic code from BlockPainter. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Mac expectations, not sure why this is changed Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/TestExpectations ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/paint/BlockPainter.cpp
diff --git a/Source/core/paint/BlockPainter.cpp b/Source/core/paint/BlockPainter.cpp
index 4fa00e8617878dcf7ad0e8c77acb4ff91b72e5ca..6e67e312828a2c9ef829db64e0046a269c8cecc6 100644
--- a/Source/core/paint/BlockPainter.cpp
+++ b/Source/core/paint/BlockPainter.cpp
@@ -36,14 +36,10 @@ void BlockPainter::paint(const PaintInfo& paintInfo, const LayoutPoint& paintOff
// Check if we need to do anything at all.
// FIXME: Could eliminate the isDocumentElement() check if we fix background painting so that the LayoutView
// paints the root's background.
- // TODO(schenney): Unroll m_layoutBlock.isDocumentElement() to try to get some insight into crbug.com/475698
Node* blockNode = m_layoutBlock.node();
RELEASE_ASSERT(blockNode || m_layoutBlock.isAnonymous());
if (blockNode) {
- TreeScope& blockTreescope = blockNode->treeScope(); // Will crash on bad node
- Document& blockDocument = blockTreescope.document(); // Will crash in bad treeScope
- Element* blockDocumentElement = blockDocument.documentElement(); // Will crash on bad TreeScope::m_document
- if (blockDocumentElement != blockNode) {
+ if (m_layoutBlock.isDocumentElement()) {
chrishtr 2015/07/13 17:09:40 I think this conditional needs to be inverted. It
Stephen Chennney 2015/07/20 17:42:30 Can't believe I messed this up, and nothing broke
LayoutRect overflowBox = overflowRectForPaintRejection();
m_layoutBlock.flipForWritingMode(overflowBox);
overflowBox.moveBy(adjustedPaintOffset);
« no previous file with comments | « LayoutTests/TestExpectations ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698