Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 12051090: Move all <webview> tests to web_view directory (Closed)

Created:
7 years, 11 months ago by Fady Samuel
Modified:
7 years, 11 months ago
Reviewers:
miket_OOO
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Move all <webview> tests to web_view directory As we add more <webview> tests, we've been adding more directories under chrome/test/data/extensions/platform_apps. Moving all the tests to one directory makes things easier to manage, and allows all future <webview> tests to reside in one place. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178992

Patch Set 1 #

Patch Set 2 : Broken upload #

Patch Set 3 : Merge with ToT #

Patch Set 4 : Merged with ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -577 lines) Patch
M chrome/browser/extensions/web_view_browsertest.cc View 3 3 chunks +10 lines, -10 lines 0 comments Download
A + chrome/test/data/extensions/platform_apps/web_view/isolation/cookie.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/extensions/platform_apps/web_view/isolation/cookie2.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/extensions/platform_apps/web_view/isolation/main.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/extensions/platform_apps/web_view/isolation/main.js View 1 chunk +7 lines, -7 lines 0 comments Download
A + chrome/test/data/extensions/platform_apps/web_view/isolation/manifest.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/extensions/platform_apps/web_view/isolation/storage.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/extensions/platform_apps/web_view/isolation/storage1.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/extensions/platform_apps/web_view/isolation/storage2.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/extensions/platform_apps/web_view/isolation/test.js View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/extensions/platform_apps/web_view/main.html View 1 chunk +0 lines, -13 lines 0 comments Download
D chrome/test/data/extensions/platform_apps/web_view/main.js View 1 chunk +0 lines, -225 lines 0 comments Download
D chrome/test/data/extensions/platform_apps/web_view/manifest.json View 1 chunk +0 lines, -12 lines 0 comments Download
A + chrome/test/data/extensions/platform_apps/web_view/shim/main.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/extensions/platform_apps/web_view/shim/main.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/extensions/platform_apps/web_view/shim/manifest.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/extensions/platform_apps/web_view/shim/test.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/extensions/platform_apps/web_view/src_attribute/main.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/extensions/platform_apps/web_view/src_attribute/main.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/extensions/platform_apps/web_view/src_attribute/manifest.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/extensions/platform_apps/web_view/src_attribute/test.js View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/test/data/extensions/platform_apps/web_view/test.js View 1 chunk +0 lines, -7 lines 0 comments Download
D chrome/test/data/extensions/platform_apps/web_view_isolation/cookie.html View 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/test/data/extensions/platform_apps/web_view_isolation/cookie2.html View 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/test/data/extensions/platform_apps/web_view_isolation/main.html View 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/test/data/extensions/platform_apps/web_view_isolation/main.js View 1 chunk +0 lines, -35 lines 0 comments Download
D chrome/test/data/extensions/platform_apps/web_view_isolation/manifest.json View 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/test/data/extensions/platform_apps/web_view_isolation/storage.js View 1 chunk +0 lines, -88 lines 0 comments Download
D chrome/test/data/extensions/platform_apps/web_view_isolation/storage1.html View 1 chunk +0 lines, -13 lines 0 comments Download
D chrome/test/data/extensions/platform_apps/web_view_isolation/storage2.html View 1 chunk +0 lines, -13 lines 0 comments Download
D chrome/test/data/extensions/platform_apps/web_view_isolation/test.js View 1 chunk +0 lines, -7 lines 0 comments Download
D chrome/test/data/extensions/platform_apps/web_view_src_attribute/main.html View 1 chunk +0 lines, -14 lines 0 comments Download
D chrome/test/data/extensions/platform_apps/web_view_src_attribute/main.js View 1 chunk +0 lines, -82 lines 0 comments Download
D chrome/test/data/extensions/platform_apps/web_view_src_attribute/manifest.json View 1 chunk +0 lines, -12 lines 0 comments Download
D chrome/test/data/extensions/platform_apps/web_view_src_attribute/test.js View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Fady Samuel
7 years, 11 months ago (2013-01-25 17:05:15 UTC) #1
miket_OOO
LGTM. Two things: 1. I reviewed the two modified files, but otherwise am taking your ...
7 years, 11 months ago (2013-01-25 17:20:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/12051090/2001
7 years, 11 months ago (2013-01-25 17:23:44 UTC) #3
commit-bot: I haz the power
Failed to apply patch for chrome/browser/extensions/web_view_browsertest.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 11 months ago (2013-01-25 17:23:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/12051090/8001
7 years, 11 months ago (2013-01-25 18:53:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/12051090/3038
7 years, 11 months ago (2013-01-25 21:31:05 UTC) #6
commit-bot: I haz the power
7 years, 11 months ago (2013-01-26 02:08:58 UTC) #7
Message was sent while issue was closed.
Change committed as 178992

Powered by Google App Engine
This is Rietveld 408576698