Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 12051058: Allow monomorphic loads when static type is known. (Closed)

Created:
7 years, 11 months ago by Michael Starzinger
Modified:
7 years, 11 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Allow monomorphic loads when static type is known. This allows Crankshaft to generate monomorphic loads when the receiver type is statically known even though the load site has polymorphic type feedback. This applies to inlined constructor calls and literals. R=jkummerow@chromium.org TEST=mjsunit/compiler/property-static Committed: http://code.google.com/p/v8/source/detail?r=13500

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -11 lines) Patch
M src/hydrogen.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M src/hydrogen-instructions.h View 3 chunks +15 lines, -0 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +5 lines, -0 lines 0 comments Download
A + test/mjsunit/compiler/property-static.js View 1 chunk +38 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Michael Starzinger
7 years, 11 months ago (2013-01-24 12:05:41 UTC) #1
Jakob Kummerow
7 years, 11 months ago (2013-01-24 17:33:47 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698