sdk/lib/_internal/compiler/implementation/native_handler.dart - Issue 12051056: Allow native classes to mixin behavior from an ordinary Dart class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/native_handler.dart

Issue 12051056: Allow native classes to mixin behavior from an ordinary Dart class. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Refactor. Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart ('K') | « sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart ('k') | tests/compiler/dart2js_native/native_mixin_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/native_handler.dart

diff --git a/sdk/lib/_internal/compiler/implementation/native_handler.dart b/sdk/lib/_internal/compiler/implementation/native_handler.dart

index f0c82013a66f3118a424fe816480dfbae1461e03..e3e7bbe1319bfab8cd6233c16c7b014333cec8f1 100644

--- a/sdk/lib/_internal/compiler/implementation/native_handler.dart

+++ b/sdk/lib/_internal/compiler/implementation/native_handler.dart

@@ -437,8 +437,14 @@ class NativeCodegenEnqueuer extends NativeEnqueuerBase {

subtypes.add(cls);

}

+ ClassElement superclass = cls.superclass;

ngeoffray 2013/01/24 11:55:53 Please add a comment here.

+ while (superclass != null && superclass.isMixinApplication) {

+ assert(!superclass.isNative());

+ superclass = superclass.superclass;

+ }

List<Element> directSubtypes = emitter.directSubtypes.putIfAbsent(

- cls.superclass,

+ superclass,

() => <ClassElement>[]);

directSubtypes.add(cls);

}