Issue 12051048: Refactor (many) IPC tests, notably most of the multiprocess tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12051048: Refactor (many) IPC tests, notably most of the multiprocess tests. (Closed)

Created:
7 years, 11 months ago by viettrungluu

Modified:
7 years, 11 months ago

Reviewers:
Tom Sepez, brettw

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Refactor (many) IPC tests, notably most of the multiprocess tests. This factors out common code and, more importantly/usefully, makes test-specific code more local, and thus easier to add new tests and maintain existing ones. In particular, this allows you to add a new test "client" (running in another process) without modifying ipc_test_base.*. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178901

Patch Set 1 #

Patch Set 2 : oops, still need ipc_multiprocess_test.* #

Patch Set 3 : fix win compile, hopefully #

Patch Set 4 : fix stupid "typo" #

Total comments: 1

Patch Set 5 : . #

Patch Set 6 : fix win #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+472 lines, -518 lines)			Patch
M	ipc/ipc.gyp	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	ipc/ipc_channel_unittest.cc	View	1 2 3 4 5	6 chunks	+132 lines, -198 lines	0 comments	Download
M	ipc/ipc_fuzzing_tests.cc	View	1 2 3 4 5	4 chunks	+46 lines, -56 lines	0 comments	Download
D	ipc/ipc_multiprocess_test.h	View	1 2 3 4	1 chunk	+11 lines, -7 lines	0 comments	Download
D	ipc/ipc_multiprocess_test.cc	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	ipc/ipc_perftests.cc	View	1 2 3 4 5	7 chunks	+22 lines, -32 lines	0 comments	Download
M	ipc/ipc_send_fds_test.cc	View	1 2 3 4 5	6 chunks	+72 lines, -94 lines	0 comments	Download
M	ipc/ipc_test_base.h	View	1 2 3 4 5	1 chunk	+76 lines, -23 lines	0 comments	Download
M	ipc/ipc_test_base.cc	View	1 2 3 4 5	2 chunks	+88 lines, -86 lines	0 comments	Download
M	ipc/sync_socket_unittest.cc	View	1 2 3 4 5	5 chunks	+18 lines, -20 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

brettw

If I make the font small enough, do some vodka shots, and squint, this patch ...

7 years, 11 months ago (2013-01-24 20:39:48 UTC) #2

LGTM.

Expand Messages | Collapse Messages