Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 12051037: Fix selenium to detect and handle browser crashes. (Closed)

Created:
7 years, 11 months ago by ricow1
Modified:
7 years, 10 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix selenium to detect and handle browser crashes. Some context: On windows, selenium will be hanging a chrome browser crashes and additional to this we would actually not get information that the browser crashed, we would get this as a failing test. This change basically sets up a python timer that will trigger us to close the browser using browser.service.stop() (I suspect that when the browser crashes and does not respond in time selenium will call browser.quit which will be blocking on trying to kill the remote service). In addition, this changes the test_runner to handle a crash exitcode correctly (we will set it to -10 in the bacth runner, I don't know why, but I dont want to change that in this cl). The current hasCrashed getter will mask out errors that it does not recognize as valid windows crashes (of which -10 is not one since it will have a bunch of set bits in the middle of the bit pattern). I changed this to explictily recognize the -10 value. Input on why we have that value is welcome Committed: https://code.google.com/p/dart/source/detail?r=17752

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -2 lines) Patch
M tools/testing/dart/test_runner.dart View 3 chunks +8 lines, -1 line 0 comments Download
M tools/testing/run_selenium.py View 4 chunks +27 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
ricow1
7 years, 11 months ago (2013-01-23 14:03:14 UTC) #1
kustermann
lgtm
7 years, 11 months ago (2013-01-23 14:12:00 UTC) #2
Emily Fortuna
7 years, 11 months ago (2013-01-23 19:05:52 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698