Issue 12051031: Added "dart:chrome" to the compiler's list of libraries allowed to use convertDartClosureToJS(), an…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12051031: Added "dart:chrome" to the compiler's list of libraries allowed to use convertDartClosureToJS(), an… (Closed)

Created:
7 years, 11 months ago by sashab

Modified:
7 years, 11 months ago

Reviewers:
benwells1, benwells, vsm, Emily Fortuna, sra1, blois, ahe, sra

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Added "dart:chrome" to the compiler's list of libraries allowed to use convertDartClosureToJS(), and other internal library functions. Committed: https://code.google.com/p/dart/source/detail?r=17615

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	sdk/lib/_internal/compiler/implementation/compiler.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ahe

7 years, 11 months ago (2013-01-23 20:05:22 UTC) #3

LGTM

This enables the use of all "foreign" functions, not just JS. Be careful :-)

This reminds me: be extra careful with the type annotations used in the JS
function. I suggest using sra as a local reviewer for that. Stephen knows this
system very well and can help you avoid common mistakes.

What is tricky about the type annotations is that they are "concrete" type, mean
exactly the class referred to, not its subclasses. Also, not null. So most of
the time, use an empty string (dynamic) or "primitive" types when you know that
it can't be null.

Expand Messages | Collapse Messages