Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(34)

Issue 1205103003: Parameterize PinchViewportTest for root layer scrolling. (Closed)

Created:
4 years, 10 months ago by skobes
Modified:
4 years, 10 months ago
Reviewers:
dsinclair
CC:
blink-reviews, szager1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Parameterize PinchViewportTest for root layer scrolling. This is similar to what http://crrev.com/1155313003 did for WebFrameTest. Some test cases already pass, and some are fixed here by updating the test to use layoutViewportScrollableArea() instead of directly accessing the FrameView. A few test cases fail non-trivially; they remain un-parameterized here, and will be addressed in later patches. BUG=490942 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197775

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -54 lines) Patch
M Source/web/tests/PinchViewportTest.cpp View 42 chunks +90 lines, -54 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
skobes
(Thanks to szager for starting the patch.)
4 years, 10 months ago (2015-06-24 19:47:07 UTC) #5
dsinclair
lgtm
4 years, 10 months ago (2015-06-24 19:55:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1205103003/60001
4 years, 10 months ago (2015-06-24 19:55:40 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2015-06-24 20:11:37 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197775

Powered by Google App Engine
This is Rietveld 408576698