Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1355)

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/builder.dart

Issue 12051013: Cleanup how we handle side effects in HInstruction and put the right flags for HIs, modulo, truncat… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/ssa/builder.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/ssa/builder.dart (revision 17401)
+++ sdk/lib/_internal/compiler/implementation/ssa/builder.dart (working copy)
@@ -2623,9 +2623,9 @@
checks.add(call);
index++;
});
- instruction = new HIs.withArgumentChecks(type, expression, checks);
+ instruction = new HIs(type, <HInstruction>[expression]..addAll(checks));
kasperl 2013/01/23 07:06:21 Not sure the type annotations on the list literals
ngeoffray 2013/01/23 09:23:01 I actually prefer keeping them, making sure checke
} else {
- instruction = new HIs(type, expression);
+ instruction = new HIs(type, <HInstruction>[expression]);
}
if (isNot) {
add(instruction);
@@ -4398,7 +4398,8 @@
compiler.cancel('On with unresolved type',
node: catchBlock.type);
}
- HInstruction condition = new HIs(type, unwrappedException);
+ HInstruction condition =
+ new HIs(type, <HInstruction>[unwrappedException]);
push(condition);
}
else {
@@ -4416,7 +4417,8 @@
if (type == null) {
compiler.cancel('Catch with unresolved type', node: catchBlock);
}
- condition = new HIs(type, unwrappedException, nullOk: true);
+ condition =
+ new HIs(type, <HInstruction>[unwrappedException], nullOk: true);
push(condition);
}
}

Powered by Google App Engine
This is Rietveld 408576698