Cleanup how we handle side effects in HInstruction and put the right flags for HIs, modulo, truncat…

sdk/lib/_internal/compiler/implementation/ssa/builder.dart

Index: sdk/lib/_internal/compiler/implementation/ssa/builder.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/ssa/builder.dart	(revision 17401)
+++ sdk/lib/_internal/compiler/implementation/ssa/builder.dart	(working copy)
@@ -2623,9 +2623,9 @@
           checks.add(call);
           index++;
         });
-        instruction = new HIs.withArgumentChecks(type, expression, checks);
+        instruction = new HIs(type, <HInstruction>[expression]..addAll(checks));

[kasperl, 2013/01/23 07:06:21]

Not sure the type annotations on the list literals are really necessary. They do
clutter up the code somewhat.

[ngeoffray, 2013/01/23 09:23:01]

I actually prefer keeping them, making sure checked mode will catch any invalid
store into the list.

       } else {
-        instruction = new HIs(type, expression);
+        instruction = new HIs(type, <HInstruction>[expression]);
       }
       if (isNot) {
         add(instruction);
@@ -4398,7 +4398,8 @@
             compiler.cancel('On with unresolved type',
                             node: catchBlock.type);
           }
-          HInstruction condition = new HIs(type, unwrappedException);
+          HInstruction condition =
+              new HIs(type, <HInstruction>[unwrappedException]);
           push(condition);
         }
         else {
@@ -4416,7 +4417,8 @@
             if (type == null) {
               compiler.cancel('Catch with unresolved type', node: catchBlock);
             }
-            condition = new HIs(type, unwrappedException, nullOk: true);
+            condition =
+                new HIs(type, <HInstruction>[unwrappedException], nullOk: true);
             push(condition);
           }
         }