Cleanup how we handle side effects in HInstruction and put the right flags for HIs, modulo, truncat…

tests/compiler/dart2js/mock_compiler.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library mock_compiler;
 
 import 'dart:collection';
 import 'dart:uri';
 
 import '../../../sdk/lib/_internal/compiler/compiler.dart' as api;
@@ skipping 65 matching lines @@
     operator <<(other) {}
     operator >>(other) {}
     operator |(other) {}
     operator &(other) {}
     operator ^(other) {}
     operator >(other) {}
     operator >=(other) {}
     operator <(other) {}
     operator <=(other) {}
     operator ==(other) {}
+    operator %(other) {}
   }
   class JSInt {
   }
   class JSDouble {
   }
   class JSNull {
   }
   class JSBool {
   }
   class JSFunction {
@@ skipping 233 matching lines @@
   operator []=(Node node, Element element) {
     map[node] = element;
   }
 
   operator [](Node node) => map[node];
 
   void remove(Node node) {
     map.remove(node);
   }
 }