Cleanup how we handle side effects in HInstruction and put the right flags for HIs, modulo, truncat…

sdk/lib/_internal/compiler/implementation/ssa/tracer.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library tracer;
 
 import 'dart:io';
 import 'ssa.dart';
 import '../js_backend/js_backend.dart';
 import '../dart2jslib.dart';
@@ skipping 256 matching lines @@
     }
     return "Continue: (B${target.id})";
   }
 
   String visitDivide(HDivide node) => handleInvokeBinary(node, '/');
 
   String visitExit(HExit node) => "exit";
 
   String visitFieldGet(HFieldGet node) {
     String fieldName = node.element.name.slowToString();
-    return 'get ${temporaryId(node.receiver)}.$fieldName';
+    return 'field get ${temporaryId(node.receiver)}.$fieldName';
   }
 
   String visitFieldSet(HFieldSet node) {
     String valueId = temporaryId(node.value);
     String fieldName = node.element.name.slowToString();
-    return 'set ${temporaryId(node.receiver)}.$fieldName to $valueId';
+    return 'field set ${temporaryId(node.receiver)}.$fieldName to $valueId';
   }
 
-  String visitLocalGet(HLocalGet node) => visitFieldGet(node);
-  String visitLocalSet(HLocalSet node) => visitFieldSet(node);
+  String visitLocalGet(HLocalGet node) {
+    String localName = node.element.name.slowToString();
+    return 'local get ${temporaryId(node.local)}.$localName';
+  }
+
+  String visitLocalSet(HLocalSet node) {
+    String valueId = temporaryId(node.value);
+    String localName = node.element.name.slowToString();
+    return 'local set ${temporaryId(node.local)}.$localName to $valueId';
+  }
 
   String visitGoto(HGoto node) {
     HBasicBlock target = currentBlock.successors[0];
     return "Goto: (B${target.id})";
   }
 
   String visitGreater(HGreater node) => handleInvokeBinary(node, '>');
   String visitGreaterEqual(HGreaterEqual node) {
     handleInvokeBinary(node, '>=');
   }
@@ skipping 245 matching lines @@
   }
 
   String visitTypeConversion(HTypeConversion node) {
     return "TypeConversion: ${temporaryId(node.checkedInput)} to ${node.type}";
   }
 
   String visitRangeConversion(HRangeConversion node) {
     return "RangeConversion: ${node.checkedInput}";
   }
 }