Cleanup how we handle side effects in HInstruction and put the right flags for HIs, modulo, truncat…

sdk/lib/_internal/compiler/implementation/ssa/builder.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of ssa;
 
 /**
  * A special element for the extra parameter taken by intercepted
  * methods. We need to override [Element.computeType] because our
  * optimizers may look at its declared type.
@@ skipping 2605 matching lines @@
               createForeign('#[#]', 'Object', [typeInfo, position]);
           add(typeArgument);
           // Create the call to isSubtype.
           List<HInstruction> inputs =
               <HInstruction>[isSubtype, typeArgument, representation];
           HInstruction call = new HInvokeStatic(inputs);
           add(call);
           checks.add(call);
           index++;
         });
-        instruction = new HIs.withArgumentChecks(type, expression, checks);
+        instruction = new HIs(type, <HInstruction>[expression]..addAll(checks));
       } else {
-        instruction = new HIs(type, expression);
+        instruction = new HIs(type, <HInstruction>[expression]);
       }
       if (isNot) {
         add(instruction);
         instruction = new HNot(instruction);
       }
       push(instruction);
     } else if (const SourceString("as") == op.source) {
       visit(node.receiver);
       HInstruction expression = pop();
       Node argument = node.arguments.head;
@@ skipping 1752 matching lines @@
       tryInstruction.exception = exception;
       Link<Node> link = node.catchBlocks.nodes;
 
       void pushCondition(CatchBlock catchBlock) {
         if (catchBlock.onKeyword != null) {
           DartType type = elements.getType(catchBlock.type);
           if (type == null) {
             compiler.cancel('On with unresolved type',
                             node: catchBlock.type);
           }
-          HInstruction condition = new HIs(type, unwrappedException);
+          HInstruction condition =
+              new HIs(type, <HInstruction>[unwrappedException]);
           push(condition);
         }
         else {
           VariableDefinitions declaration = catchBlock.formals.nodes.head;
           HInstruction condition = null;
           if (declaration.type == null) {
             condition = graph.addConstantBool(true, constantSystem);
             stack.add(condition);
           } else {
             // TODO(aprelev@gmail.com): Once old catch syntax is removed
             // "if" condition above and this "else" branch should be deleted as
             // type of declared variable won't matter for the catch
             // condition.
             DartType type = elements.getType(declaration.type);
             if (type == null) {
               compiler.cancel('Catch with unresolved type', node: catchBlock);
             }
-            condition = new HIs(type, unwrappedException, nullOk: true);
+            condition =
+                new HIs(type, <HInstruction>[unwrappedException], nullOk: true);
             push(condition);
           }
         }
       }
 
       void visitThen() {
         CatchBlock catchBlock = link.head;
         link = link.tail;
         if (catchBlock.exception != null) {
           localsHandler.updateLocal(elements[catchBlock.exception],
@@ skipping 511 matching lines @@
           new HSubGraphBlockInformation(elseBranch.graph));
 
     HBasicBlock conditionStartBlock = conditionBranch.block;
     conditionStartBlock.setBlockFlow(info, joinBlock);
     SubGraph conditionGraph = conditionBranch.graph;
     HIf branch = conditionGraph.end.last;
     assert(branch is HIf);
     branch.blockInformation = conditionStartBlock.blockFlow;
   }
 }