Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(18)

Issue 1205083002: [DevTools] Show warning on device mode button when network throttling is enabled. (Closed)

Created:
4 years, 10 months ago by dgozman
Modified:
4 years, 10 months ago
Reviewers:
pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, yurys+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[DevTools] Show warning on device mode button when network throttling is enabled. BUG=504027 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197914

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M Source/devtools/front_end/emulation/DeviceModeButton.js View 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
dgozman
Take a look please.
4 years, 10 months ago (2015-06-24 15:45:35 UTC) #2
pfeldman
lgtm
4 years, 10 months ago (2015-06-26 12:45:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1205083002/1
4 years, 10 months ago (2015-06-26 12:47:21 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2015-06-26 13:52:52 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197914

Powered by Google App Engine
This is Rietveld 408576698