Fix user pod not always scroll to the center after VK shows up

chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc

Index: chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc
diff --git a/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc b/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc
index b5f2b6c31b532b4b32f3fbd5291df0926d79e2e5..852df4c57c34308ca1f8da4f2667404e4b9ab828 100644
--- a/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc
+++ b/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc
@@ -230,10 +230,6 @@ void CoreOobeHandler::ShowControlBar(bool show) {
   CallJS("showControlBar", show);
 }
 
-void CoreOobeHandler::SetKeyboardState(bool shown, const gfx::Rect& bounds) {
-  CallJS("setKeyboardState", shown, bounds.width(), bounds.height());
-}
-
 void CoreOobeHandler::SetClientAreaSize(int width, int height) {
   CallJS("setClientAreaSize", width, height);
 }
@@ -387,7 +383,6 @@ void CoreOobeHandler::UpdateKeyboardState() {
   if (keyboard_controller) {

[flackr, 2015/06/25 18:01:37]

Is it possible for the keyboard_controller to go away? For example, if a
physical keyboard is plugged in and we have automatic keyboard detection? If so,
I'm guessing we should always update the control bar state, just set it to true
if there is no controller.

[bshe, 2015/06/25 21:15:07]

I am not sure I understand you correctly. But if keyboard_controller is null
here, the control bar should already set to visible before this code. We
probably dont need to set it again here? This only called during initialization
stage, hot plug a keyboard wont trigger this code path I think. 

[flackr, 2015/06/25 21:49:28]

So my thoughts are we are on the lock screen with virtual keyboard showing so we
hide the control bar. Then the user plugs in a usb keyboard which calls
Shell::DeactivateKeyboard() which destroys the keyboard controller and we get in
here and don't reshow the control bar.

[bshe, 2015/06/26 17:22:48]

I see what you mean. When shell deactivates keyboard, we send a bounds changed
notification before reset the keyboard controller instance.
(https://code.google.com/p/chromium/codesearch/#chromium/src/ash/root_window_c...)
After we send the notification, the visibility of control bar should be set
correctly by WebUIScreenLocker or LoginDisplayHostImpl in
onKeyboardBoundsChanging 

     gfx::Rect bounds = keyboard_controller->current_keyboard_bounds();
     ShowControlBar(bounds.IsEmpty());
-    SetKeyboardState(!bounds.IsEmpty(), bounds);
   }
 }