Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 1205043002: Enable Chrome Canary tests on Travis (Closed)

Created:
5 years, 6 months ago by vsm
Modified:
5 years, 6 months ago
Reviewers:
Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Enable Chrome Canary browser tests on Travis I created a karma branch to test this on travis - see bottom of the log here: https://travis-ci.org/dart-lang/dev_compiler/jobs/68106290 R=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/eb3ce0f239305bef7729b5e844e8a0c05a3058f0

Patch Set 1 #

Total comments: 8

Patch Set 2 : Clean up travis karma passes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -13 lines) Patch
M .travis.yml View 1 1 chunk +11 lines, -0 lines 0 comments Download
M karma.conf.js View 5 chunks +20 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
vsm
5 years, 6 months ago (2015-06-24 13:23:26 UTC) #2
Jennifer Messerly
minor comments, but LGTM! https://codereview.chromium.org/1205043002/diff/1/.travis.yml File .travis.yml (right): https://codereview.chromium.org/1205043002/diff/1/.travis.yml#newcode7 .travis.yml:7: - pub global activate dart_coveralls ...
5 years, 6 months ago (2015-06-24 15:44:23 UTC) #3
vsm
https://codereview.chromium.org/1205043002/diff/1/.travis.yml File .travis.yml (right): https://codereview.chromium.org/1205043002/diff/1/.travis.yml#newcode7 .travis.yml:7: - pub global activate dart_coveralls On 2015/06/24 15:44:22, John ...
5 years, 6 months ago (2015-06-24 17:19:55 UTC) #4
vsm
https://codereview.chromium.org/1205043002/diff/1/karma.conf.js File karma.conf.js (right): https://codereview.chromium.org/1205043002/diff/1/karma.conf.js#newcode23 karma.conf.js:23: 'lib/runtime/dart_*.js', On 2015/06/24 15:44:22, John Messerly wrote: > could ...
5 years, 6 months ago (2015-06-24 17:21:03 UTC) #5
vsm
5 years, 6 months ago (2015-06-24 17:21:19 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
eb3ce0f239305bef7729b5e844e8a0c05a3058f0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698