chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchNetworkCommunicator.java - Issue 1205033005: Adds selection expansion support for Contextual Search.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchNetworkCommunicator.java

Issue 1205033005: Adds selection expansion support for Contextual Search. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix expansions Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchSelectionController.java » ('j') | chrome/browser/android/contextualsearch/contextual_search_delegate.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchNetworkCommunicator.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchNetworkCommunicator.java b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchNetworkCommunicator.java

index 3a823da5b36ec302aa6d75f1c56b3fba34513efa..444c5160df41b9cbb8569a3990d8386700a068f8 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchNetworkCommunicator.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchNetworkCommunicator.java

@@ -29,9 +29,14 @@ public interface ContextualSearchNetworkCommunicator {

* @param displayText the text to display that describes the search term.

* @param alternateTerm the alternate search term.

* @param doPreventPreload whether to prevent preloading the search result.

+ * @param selectionStartAdjust The start offset adjustment of the selection to use to highlight

+ * the search term.

+ * @param selectionEndAdjust The end offset adjustment of the selection to use to highlight

+ * the search term.

void handleSearchTermResolutionResponse(boolean isNetworkUnavailable, int responseCode,

- String searchTerm, String displayText, String alternateTerm, boolean doPreventPreload);

+ String searchTerm, String displayText, String alternateTerm, boolean doPreventPreload,

+ int selectionStartAdjust, int selectionEndAdjust);

/**

* Loads a URL in the search content view.