content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java - Issue 1205033005: Adds selection expansion support for Contextual Search.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

Issue 1205033005: Adds selection expansion support for Contextual Search. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/render_view_host_impl.h ('K') | « content/common/view_messages.h ('k') | content/public/android/java/src/org/chromium/content_public/browser/WebContents.java » ('j') | content/renderer/render_view_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java b/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

index fc31ad9f25061dd5ab2519c81bfebdde6bb85d96..d2b2b4e49a7ae367cdbf8799e061a6f7c7374891 100644

--- a/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

+++ b/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

@@ -238,6 +238,12 @@ import java.util.UUID;

}

@Override

+ public void moveSelectionByCharacterOffset(int startAdjust, int endAdjust) {

+ nativeMoveSelectionByCharacterOffset(

+ mNativeWebContentsAndroid, startAdjust, endAdjust);

+ }

+ @Override

public String getUrl() {

return nativeGetURL(mNativeWebContentsAndroid);

}

@@ -361,6 +367,8 @@ import java.util.UUID;

private native void nativeShowImeIfNeeded(long nativeWebContentsAndroid);

private native void nativeScrollFocusedEditableNodeIntoView(long nativeWebContentsAndroid);

private native void nativeSelectWordAroundCaret(long nativeWebContentsAndroid);

+ private native void nativeMoveSelectionByCharacterOffset(

+ long nativeWebContentsAndroid, int startAdjust, int endAdjust);

private native String nativeGetURL(long nativeWebContentsAndroid);

private native String nativeGetLastCommittedURL(long nativeWebContentsAndroid);

private native boolean nativeIsIncognito(long nativeWebContentsAndroid);