[Aura] Fix regressions breaking embedded flash fullscreen.

[Aura] Fix regressions breaking embedded flash fullscreen.

1. Set WindowType to "control" in RWHVAura::InitAsChild().  Previously, the window type was not being set, and this caused a NOTREACHED() crash at ash/wm/stacking_controller.cc:101.

2. Infinite loop freezing the browser when entering fullscreen: In WebView, AttachWebContents() and DetachWebContents() were being indirectly called from FOR_EACH_OBSERVER().  Because they were calling WebContentsObserver::Observe(), the FOR_EACH_OBSERVER loop would never terminate.

3. Clean-up: Eliminated WebView::web_contents_ member since WebView inherits from WebContentsObserver, which already has it.

TEST=Run chrome with and without --embed-flash-fullscreen command-line arg, and test switching tabs, flash fullscreen, keyboard focus, etc.  Tested on Win and Linux Aura builds.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243725

[miu, 2014-01-07 06:47:23]

ben: PTAL.  Description explains the fixes.

Context:
http://www.chromium.org/developers/design-documents/embedding-flash-fullscree...

Thanks,
Yuri

https://codereview.chromium.org/120503007/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/render_widget_host_view_aura.cc (right):

https://codereview.chromium.org/120503007/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/render_widget_host_view_aura.cc:497:
window_->SetType(ui::wm::WINDOW_TYPE_CONTROL);
I believe this is the correct type, given the comment in the RWHV interface:
https://code.google.com/p/chromium/codesearch#chromium/src/content/public/bro...

https://codereview.chromium.org/120503007/diff/1/ui/views/controls/webview/we...
File ui/views/controls/webview/webview.h (left):

https://codereview.chromium.org/120503007/diff/1/ui/views/controls/webview/we...
ui/views/controls/webview/webview.h:39: void
CreateWebContentsWithSiteInstance(content::SiteInstance* site_instance);
FYI--Old/Leftover public method, not called from anywhere.

[Ben Goodger (Google), 2014-01-08 20:58:35]

lgtm

[commit-bot: I haz the power, 2014-01-08 21:15:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/miu@chromium.org/120503007/1

[commit-bot: I haz the power, 2014-01-08 21:57:16]

Retried try job too often on linux_rel for step(s) base_unittests,
browser_tests, interactive_ui_tests, net_unittests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2014-01-08 22:05:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/miu@chromium.org/120503007/1

[commit-bot: I haz the power, 2014-01-08 22:05:40]

Failed to apply patch for
content/browser/renderer_host/render_widget_host_view_aura.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file content/browser/renderer_host/render_widget_host_view_aura.cc
  Hunk #1 FAILED at 494.
  1 out of 1 hunk FAILED -- saving rejects to file
content/browser/renderer_host/render_widget_host_view_aura.cc.rej

Patch:       content/browser/renderer_host/render_widget_host_view_aura.cc
Index: content/browser/renderer_host/render_widget_host_view_aura.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_aura.cc
b/content/browser/renderer_host/render_widget_host_view_aura.cc
index
700aece9eb79080ed3587257a661ecd65ce04b25..91d95430505bb5b907996a78e4e42222a6cd98d2
100644
--- a/content/browser/renderer_host/render_widget_host_view_aura.cc
+++ b/content/browser/renderer_host/render_widget_host_view_aura.cc
@@ -494,6 +494,7 @@
RenderWidgetHostViewAura::RenderWidgetHostViewAura(RenderWidgetHost* host)
 
 void RenderWidgetHostViewAura::InitAsChild(
     gfx::NativeView parent_view) {
+  window_->SetType(ui::wm::WINDOW_TYPE_CONTROL);
   window_->Init(ui::LAYER_TEXTURED);
   window_->SetName("RenderWidgetHostViewAura");
 }

[commit-bot: I haz the power, 2014-01-08 22:31:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/miu@chromium.org/120503007/330001

[commit-bot: I haz the power, 2014-01-09 01:25:26]

Change committed as 243725