Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 120503003: run aura_demo as a mojo app (Closed)

Created:
7 years ago by Ben Goodger (Google)
Modified:
6 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, ben+aura_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, kalyank, sadrul, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Patch Set 8 : it works! #

Patch Set 9 : . #

Patch Set 10 : actually works this time #

Patch Set 11 : . #

Patch Set 12 : . #

Patch Set 13 : builds on X11 now too #

Total comments: 2

Patch Set 14 : fix comments #

Patch Set 15 : . #

Patch Set 16 : . #

Patch Set 17 : . #

Patch Set 18 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+791 lines, -36 lines) Patch
A mojo/examples/aura_demo/DEPS View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +11 lines, -0 lines 0 comments Download
A mojo/examples/aura_demo/aura_demo.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +213 lines, -0 lines 0 comments Download
A + mojo/examples/aura_demo/demo_context_factory.h View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +21 lines, -15 lines 0 comments Download
A mojo/examples/aura_demo/demo_context_factory.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +133 lines, -0 lines 0 comments Download
A + mojo/examples/aura_demo/demo_screen.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +25 lines, -19 lines 0 comments Download
A mojo/examples/aura_demo/demo_screen.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +78 lines, -0 lines 0 comments Download
A mojo/examples/aura_demo/root_window_host_mojo.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +74 lines, -0 lines 0 comments Download
A mojo/examples/aura_demo/root_window_host_mojo.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +176 lines, -0 lines 0 comments Download
M mojo/examples/compositor_app/gles2_client_impl.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M mojo/mojo.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +7 lines, -0 lines 0 comments Download
M mojo/mojo_examples.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +50 lines, -0 lines 0 comments Download
M mojo/services/native_viewport/native_viewport_win.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/native_viewport/native_viewport_x11.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Ben Goodger (Google)
6 years, 11 months ago (2014-01-06 23:02:23 UTC) #1
sky
Fix the ownership and LGTM https://codereview.chromium.org/120503003/diff/480001/mojo/examples/aura_demo/DEPS File mojo/examples/aura_demo/DEPS (right): https://codereview.chromium.org/120503003/diff/480001/mojo/examples/aura_demo/DEPS#newcode9 mojo/examples/aura_demo/DEPS:9: "+gpu/command_buffer/client", nit: sort https://codereview.chromium.org/120503003/diff/480001/mojo/examples/aura_demo/aura_demo.cc ...
6 years, 11 months ago (2014-01-06 23:19:43 UTC) #2
Ben Goodger (Google)
6 years, 11 months ago (2014-01-07 21:46:09 UTC) #3
Message was sent while issue was closed. 
Committed patchset #18 manually as r243393 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698