Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2261)

Unified Diff: Source/modules/credentialmanager/CredentialsContainer.cpp

Issue 1205003002: Credential Management: Implement CredentialRequestOptions. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/credentialmanager/CredentialsContainer.cpp
diff --git a/Source/modules/credentialmanager/CredentialsContainer.cpp b/Source/modules/credentialmanager/CredentialsContainer.cpp
index 5ebd2614c64d439ca3ee094e993dcd336a7d1728..ab3578615bb37f2740ffc4d9823227aebb731518 100644
--- a/Source/modules/credentialmanager/CredentialsContainer.cpp
+++ b/Source/modules/credentialmanager/CredentialsContainer.cpp
@@ -13,7 +13,9 @@
#include "core/dom/ExecutionContext.h"
#include "modules/credentialmanager/Credential.h"
#include "modules/credentialmanager/CredentialManagerClient.h"
+#include "modules/credentialmanager/CredentialRequestOptions.h"
#include "modules/credentialmanager/FederatedCredential.h"
+#include "modules/credentialmanager/FederatedCredentialRequestOptions.h"
#include "modules/credentialmanager/PasswordCredential.h"
#include "platform/weborigin/SecurityOrigin.h"
#include "public/platform/Platform.h"
@@ -114,15 +116,23 @@ static bool checkBoilerplate(PassRefPtrWillBeRawPtr<ScriptPromiseResolver> resol
return true;
}
-ScriptPromise CredentialsContainer::request(ScriptState* scriptState, const Dictionary&)
+ScriptPromise CredentialsContainer::request(ScriptState* scriptState, const CredentialRequestOptions& options)
{
RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
ScriptPromise promise = resolver->promise();
if (!checkBoilerplate(resolver))
return promise;
- WebVector<WebURL> tempVector;
- CredentialManagerClient::from(scriptState->executionContext())->dispatchRequest(false, tempVector, new RequestCallbacks(resolver));
+ Vector<KURL> providers;
+ if (options.hasFederated() && options.federated().hasProviders()) {
+ for (const auto& string : options.federated().providers()) {
+ KURL url = KURL(KURL(), string);
+ if (url.isValid())
+ providers.append(url);
+ }
+ }
+
+ CredentialManagerClient::from(scriptState->executionContext())->dispatchRequest(options.suppressUI(), providers, new RequestCallbacks(resolver));
return promise;
}
« no previous file with comments | « Source/modules/credentialmanager/CredentialsContainer.h ('k') | Source/modules/credentialmanager/CredentialsContainer.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698