Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(18)

Issue 1205003002: Credential Management: Implement CredentialRequestOptions. (Closed)

Created:
4 years, 10 months ago by Mike West
Modified:
4 years, 10 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Credential Management: Implement CredentialRequestOptions. As described in [1], the request method's signature now requires a CredentialRequestOptions dictionary which wraps the various bits and pieces that will be passed in in order to request credentials. This patch puts those dictionaries in place, and wires them up to the CredentialManagerClient. [1]: https://w3c.github.io/webappsec/specs/credentialmanagement/#dictdef-credentialrequestoptions BUG=494880 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197747

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -16 lines) Patch
M LayoutTests/http/tests/credentialmanager/credentialscontainer-request-basics.html View 3 chunks +4 lines, -4 lines 0 comments Download
A + Source/modules/credentialmanager/CredentialRequestOptions.idl View 1 chunk +6 lines, -4 lines 0 comments Download
M Source/modules/credentialmanager/CredentialsContainer.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/modules/credentialmanager/CredentialsContainer.cpp View 2 chunks +13 lines, -3 lines 0 comments Download
M Source/modules/credentialmanager/CredentialsContainer.idl View 1 chunk +1 line, -1 line 0 comments Download
A + Source/modules/credentialmanager/FederatedCredentialRequestOptions.idl View 1 chunk +4 lines, -3 lines 0 comments Download
M Source/modules/modules.gypi View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Mike West
Mind taking a look? -mike
4 years, 10 months ago (2015-06-24 09:58:24 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1205003002/1
4 years, 10 months ago (2015-06-24 11:57:17 UTC) #4
jochen (gone - plz use gerrit)
lgtm
4 years, 10 months ago (2015-06-24 14:56:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1205003002/1
4 years, 10 months ago (2015-06-24 15:35:58 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2015-06-24 15:40:01 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197747

Powered by Google App Engine
This is Rietveld 408576698