Introduce InvokeMathCFunction that can be used to directly invoke mathematical function provided by…

runtime/vm/intermediate_language_ia32.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_IA32.
 #if defined(TARGET_ARCH_IA32)
 
 #include "vm/intermediate_language.h"
 
 #include "lib/error.h"
@@ skipping 2408 matching lines @@
       XmmRegister temp = locs()->temp(0).fpu_reg();
       __ DoubleRound(result, value, temp);
       break;
     }
     default:
       UNREACHABLE();
   }
 }
 
 
+LocationSummary* InvokeMathCFunctionInstr::MakeLocationSummary() const {
+  ASSERT((InputCount() == 1) || (InputCount() == 2));
+  const intptr_t kNumTemps = 0;
+  LocationSummary* result =
+      new LocationSummary(InputCount(), kNumTemps, LocationSummary::kCall);
+  result->set_in(0, Location::FpuRegisterLocation(XMM1, Location::kDouble));

[Florian Schneider, 2013/01/21 16:31:26]

Do you really need fixed locations here? You could also assign locations in a
loop from 0..InputCount()

[Vyacheslav Egorov (Google), 2013/01/21 16:50:08]

Instruction is marked as a call to ensure that register allocator takes care of
spilling.

+  if (InputCount() == 2) {
+    result->set_in(1, Location::FpuRegisterLocation(XMM2, Location::kDouble));
+  }
+  result->set_out(Location::FpuRegisterLocation(XMM1, Location::kDouble));
+  return result;
+}
+
+
+void InvokeMathCFunctionInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
+  __ enter(Immediate(0));
+  __ ReserveAlignedFrameSpace(kDoubleSize * InputCount());
+  for (intptr_t i = 0; i < InputCount(); i++) {
+    __ movsd(Address(ESP, -kDoubleSize * i), locs()->in(i).fpu_reg());
+  }
+  __ CallRuntime(TargetFunction());
+  __ fstpl(Address(ESP, 0));
+  __ movsd(locs()->out().fpu_reg(), Address(ESP, 0));
+  __ leave();
+}
+
+
 LocationSummary* PolymorphicInstanceCallInstr::MakeLocationSummary() const {
   return MakeCallSummary();
 }
 
 
 void PolymorphicInstanceCallInstr::EmitNativeCode(FlowGraphCompiler* compiler) {
   Label* deopt = compiler->AddDeoptStub(instance_call()->deopt_id(),
                                         kDeoptPolymorphicInstanceCallTestFail);
   if (ic_data().NumberOfChecks() == 0) {
     __ jmp(deopt);
@@ skipping 776 matching lines @@
                          PcDescriptors::kOther,
                          locs());
   __ Drop(2);  // Discard type arguments and receiver.
 }
 
 }  // namespace dart
 
 #undef __
 
 #endif  // defined TARGET_ARCH_IA32