Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(115)

Issue 1204953002: Introduce EditingTestBase to share code among test files for editing (Closed)

Created:
4 years, 10 months ago by yosin_UTC9
Modified:
4 years, 10 months ago
Reviewers:
tkent
CC:
blink-reviews, hajimehoshi
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Introduce EditingTestBase to share code among test files for editing This patch introduces |EditingTestBase| class for GTest base unit tests to share code among test files for avoiding code cloning. Following patches will utilize this class into: - PositionTest.cpp - StyledMarkupSerializerTest.cpp - VisibleSelection.cpp - VisibleUnits.cpp BUGS=n/a TESTS=no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197710

Patch Set 1 #

Patch Set 2 : 2015-06-24T12:46:38 Add missing |static| keyword. #

Patch Set 3 : 2015-06-24T15:31:52 Rebase for chaning bot(?) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -56 lines) Patch
M Source/core/core.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A Source/core/editing/EditingTestBase.h View 1 1 chunk +40 lines, -0 lines 0 comments Download
A Source/core/editing/EditingTestBase.cpp View 1 chunk +61 lines, -0 lines 0 comments Download
M Source/core/editing/VisiblePositionTest.cpp View 1 chunk +2 lines, -56 lines 0 comments Download

Messages

Total messages: 23 (12 generated)
yosin_UTC9
PTAL
4 years, 10 months ago (2015-06-24 02:13:54 UTC) #2
tkent
lgtm
4 years, 10 months ago (2015-06-24 02:18:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1204953002/1
4 years, 10 months ago (2015-06-24 02:18:22 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/60485)
4 years, 10 months ago (2015-06-24 03:24:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1204953002/1
4 years, 10 months ago (2015-06-24 03:25:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1204953002/20001
4 years, 10 months ago (2015-06-24 03:48:37 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/60504)
4 years, 10 months ago (2015-06-24 05:05:00 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1204953002/20001
4 years, 10 months ago (2015-06-24 05:10:34 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/60512)
4 years, 10 months ago (2015-06-24 06:30:20 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1204953002/40001
4 years, 10 months ago (2015-06-24 06:34:21 UTC) #22
commit-bot: I haz the power
4 years, 10 months ago (2015-06-24 07:31:12 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197710

Powered by Google App Engine
This is Rietveld 408576698