Source/core/dom/Element.h - Issue 1204933006: Elements moved from a shadow root to a detached tree should clear their IsInShadowTree Flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Element.h

Issue 1204933006: Elements moved from a shadow root to a detached tree should clear their IsInShadowTree Flag (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/Element.h

diff --git a/Source/core/dom/Element.h b/Source/core/dom/Element.h

index 221c8aeec54020548e849dbeca693885cb853535..0f02ebf58a95b6442ac9a859f4672e5985506703 100644

--- a/Source/core/dom/Element.h

+++ b/Source/core/dom/Element.h

@@ -796,7 +796,7 @@ inline Node::InsertionNotificationRequest Node::insertedInto(ContainerNode* inse

inline void Node::removedFrom(ContainerNode* insertionPoint)

{

- ASSERT(insertionPoint->inDocument() || isContainerNode());

+ ASSERT(insertionPoint->inDocument() || isContainerNode() || isInShadowTree());

if (insertionPoint->inDocument())

clearFlag(InDocumentFlag);

if (isInShadowTree() && !treeScope().rootNode().isShadowRoot())

« Source/core/dom/ContainerNode.cpp ('K') | « Source/core/dom/ContainerNode.cpp ('k') | no next file » | no next file with comments »