Elements moved from a shadow root to a detached tree should clear their IsInShadowTree Flag

Elements moved from a shadow root to a detached tree should clear their IsInShadowTree Flag

When an element is moved from a shadow root to a detached subtree we need to
clear down the IsInShadowTree flag on it if the subtree isn't also a shadow root.

This wasn't happening because the required call was optimized away - on the
assumption that elements in out-of-document subtrees didn't need it. I guess that
assumption pre-dated the addition of shadow-root logic to the function.

BUG=491844
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197817

[rhogan, 2015-06-24 17:46:16]

robhogan@gmail.com changed reviewers:
+ esprehn@chromium.org

[esprehn, 2015-06-24 18:27:34]

You want to change both of those callers to isInTreeScope() I think.

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[rhogan, 2015-06-24 20:20:22]

https://codereview.chromium.org/1204933006/diff/1/Source/core/dom/ContainerNo...
File Source/core/dom/ContainerNode.cpp (right):

https://codereview.chromium.org/1204933006/diff/1/Source/core/dom/ContainerNo...
Source/core/dom/ContainerNode.cpp:855: if (!node.inDocument() &&
!node.isContainerNode() && !node.isInShadowTree())
Strictly, shouldn't this be: if (inDocument() ..  rather than if
(!node.inDocument().. , given the assertion is on |this| in removedFrom? I
realize if node is inDocument then |this| probably is too, but stranger things
have happened I guess?

[rhogan, 2015-06-24 20:34:42]

https://codereview.chromium.org/1204933006/diff/20001/Source/core/dom/Element.h
File Source/core/dom/Element.h (right):

https://codereview.chromium.org/1204933006/diff/20001/Source/core/dom/Element...
Source/core/dom/Element.h:799: ASSERT(insertionPoint->inDocument() ||
isContainerNode() || isInShadowTree());
I didn't use isInTreeScope() here as it would expand the ASSERT to allow
inDocument() as an alternative to insertionPoint->inDocument, and that appears
to be unnecessary.

[esprehn, 2015-06-24 22:32:51]

lgtm

[rhogan, 2015-06-25 12:27:58]

The CQ bit was checked by robhogan@gmail.com

[commit-bot: I haz the power, 2015-06-25 12:28:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1204933006/20001

[commit-bot: I haz the power, 2015-06-25 12:31:30]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197817