Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(9)

Issue 1204933003: Add StyledMarkupSerializerTest.ShadowTreeStyle (Closed)

Created:
4 years, 10 months ago by hajimehoshi
Modified:
4 years, 10 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, blink-reviews-style_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add StyledMarkupSerializerTest.ShadowTreeStyle This CL adds a new test case to test that serializing nodes on the composed tree should have same results as the DOM tree including inline styles. The test uses AnnotateForInterchange, which is practical because this is used at FrameSelection. BUG=275851 TEST=webkit_unit_tests --gtest_filter=StyledMarkupSerializerTest.* Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197718

Patch Set 1 #

Total comments: 4

Patch Set 2 : yosin's review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -4 lines) Patch
M Source/core/editing/StyledMarkupSerializerTest.cpp View 1 5 chunks +39 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
hajimehoshi
PTAL
4 years, 10 months ago (2015-06-24 06:01:04 UTC) #2
yosin_UTC9
lgtm w/ nits https://codereview.chromium.org/1204933003/diff/1/Source/core/editing/StyledMarkupSerializerTest.cpp File Source/core/editing/StyledMarkupSerializerTest.cpp (right): https://codereview.chromium.org/1204933003/diff/1/Source/core/editing/StyledMarkupSerializerTest.cpp#newcode232 Source/core/editing/StyledMarkupSerializerTest.cpp:232: Element* one = document().getElementById("one"); Could you ...
4 years, 10 months ago (2015-06-24 06:15:21 UTC) #3
hajimehoshi
Thank you! https://codereview.chromium.org/1204933003/diff/1/Source/core/editing/StyledMarkupSerializerTest.cpp File Source/core/editing/StyledMarkupSerializerTest.cpp (right): https://codereview.chromium.org/1204933003/diff/1/Source/core/editing/StyledMarkupSerializerTest.cpp#newcode232 Source/core/editing/StyledMarkupSerializerTest.cpp:232: Element* one = document().getElementById("one"); On 2015/06/24 06:15:21, ...
4 years, 10 months ago (2015-06-24 06:23:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1204933003/20001
4 years, 10 months ago (2015-06-24 06:23:43 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/60523)
4 years, 10 months ago (2015-06-24 07:46:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1204933003/20001
4 years, 10 months ago (2015-06-24 07:49:09 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2015-06-24 09:19:01 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197718

Powered by Google App Engine
This is Rietveld 408576698