Use DriveResourceMetadataInterface in unit tests.

Use DriveResourceMetadataInterface in unit tests.

BUG=165844
TEST=unit tests pass.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179448

[achuithb, 2013-01-25 04:43:08]

All usage of DriveResourceMetadata needs to switch to
DriveResourceMetadataInterface.

[satorux1, 2013-01-25 05:07:37]

LGTM

[commit-bot: I haz the power, 2013-01-25 06:11:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/achuith@chromium.org/12049085/1

[achuithb, 2013-01-25 08:30:53]

One of the unit tests was failing - the fix is not trivial so could you please
take another look, Satoru-san.

[tfarina, 2013-01-26 17:46:10]

https://codereview.chromium.org/12049085/diff/3004/chrome/browser/chromeos/dr...
File chrome/browser/chromeos/drive/drive_resource_metadata_unittest.cc (right):

https://codereview.chromium.org/12049085/diff/3004/chrome/browser/chromeos/dr...
chrome/browser/chromeos/drive/drive_resource_metadata_unittest.cc:314:
base_names.push_back(entries->at(i).base_name());
nit: std::vector::at is informally banned.

use entries[i] instead

[achuithb, 2013-01-26 20:39:14]

https://codereview.chromium.org/12049085/diff/3004/chrome/browser/chromeos/dr...
File chrome/browser/chromeos/drive/drive_resource_metadata_unittest.cc (right):

https://codereview.chromium.org/12049085/diff/3004/chrome/browser/chromeos/dr...
chrome/browser/chromeos/drive/drive_resource_metadata_unittest.cc:314:
base_names.push_back(entries->at(i).base_name());
On 2013/01/26 17:46:10, tfarina wrote:
> nit: std::vector::at is informally banned.
> 
> use entries[i] instead

Can't use entries[i] since entries is a pointer; I'd have to do (*entries)[i],
which doesn't seem like much of an improvement. Do you have a pointer to the
discussion where at() was informally banned? What was the rationale?

[satorux1, 2013-01-29 04:58:12]

LGTM

https://codereview.chromium.org/12049085/diff/3004/chrome/browser/chromeos/dr...
File chrome/browser/chromeos/drive/drive_resource_metadata_unittest.cc (right):

https://codereview.chromium.org/12049085/diff/3004/chrome/browser/chromeos/dr...
chrome/browser/chromeos/drive/drive_resource_metadata_unittest.cc:314:
base_names.push_back(entries->at(i).base_name());
On 2013/01/26 20:39:14, achuith.bhandarkar wrote:
> On 2013/01/26 17:46:10, tfarina wrote:
> > nit: std::vector::at is informally banned.
> > 
> > use entries[i] instead
> 
> Can't use entries[i] since entries is a pointer; I'd have to do (*entries)[i],
> which doesn't seem like much of an improvement. Do you have a pointer to the
> discussion where at() was informally banned? What was the rationale?

->at looks just fine to me. I guess there is no need to add yet another style
rule on this minor matter.

[commit-bot: I haz the power, 2013-01-29 05:24:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/achuith@chromium.org/12049085/3004

[commit-bot: I haz the power, 2013-01-29 05:45:14]

Sorry for I got bad news for ya.
Compile failed with a clobber build on mac.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-01-29 07:47:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/achuith@chromium.org/12049085/3004

[commit-bot: I haz the power, 2013-01-29 08:07:39]

Sorry for I got bad news for ya.
Compile failed with a clobber build on mac.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-01-29 08:42:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/achuith@chromium.org/12049085/3004

[commit-bot: I haz the power, 2013-01-29 09:27:12]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-01-29 18:54:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/achuith@chromium.org/12049085/3004

[commit-bot: I haz the power, 2013-01-29 20:00:10]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-01-29 20:11:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/achuith@chromium.org/12049085/17006

[commit-bot: I haz the power, 2013-01-29 22:53:33]

Change committed as 179448