tests/compiler/dart2js/pretty_parameter_test.dart - Issue 12049067: Restrict some JS names that we might use in our JS blocks. It doesn't break for now because our JS …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/compiler/dart2js/pretty_parameter_test.dart

Issue 12049067: Restrict some JS names that we might use in our JS blocks. It doesn't break for now because our JS … (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/compiler/implementation/js_backend/namer.dart ('K') | « sdk/lib/_internal/compiler/implementation/js_backend/namer.dart ('k') | tests/compiler/dart2js_native/foreign_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tests/compiler/dart2js/pretty_parameter_test.dart

===================================================================

--- tests/compiler/dart2js/pretty_parameter_test.dart (revision 17705)

+++ tests/compiler/dart2js/pretty_parameter_test.dart (working copy)

@@ -72,7 +72,7 @@

Expect.isTrue(generated.contains(r"function(a, b) {"));

generated = compile(BAR, entry: 'bar');

- Expect.isTrue(generated.contains(r"function(eval, $$eval) {"));

+ Expect.isTrue(generated.contains(r"function($eval, $$eval) {"));

generated = compile(PARAMETER_AND_TEMP, entry: 'bar');

Expect.isTrue(generated.contains(r"print(t00)"));