Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issue 12049062: Merge 177997 (Closed)

Created:
7 years, 11 months ago by kinaba
Modified:
7 years, 11 months ago
Reviewers:
kinaba
CC:
chromium-reviews, nkostylev+watch_chromium.org, tzik+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Merge 177997 > drive: Deal with the root directory same as others in MoveOperation. > > Our current implementation of file moving is done in the following logic: > "if(source!=root) RemoveFrom(source); if(target!=root) AddTo(target)" > implicitly assuming "belonging to nowhere" means belonging to root. > But this is not the case. > > This patch removes the "if !=root" checks and treats the root as same as other directories. > > BUG=169420 > TEST=Manually test the steps in the bug report. > > Review URL: https://chromiumcodereview.appspot.com/12039005 TBR=kinaba@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178494

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -52 lines) Patch
M chrome/browser/chromeos/drive/drive_file_system_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/move_operation.h View 1 chunk +15 lines, -17 lines 0 comments Download
M chrome/browser/chromeos/drive/file_system/move_operation.cc View 3 chunks +21 lines, -33 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
kinaba
7 years, 11 months ago (2013-01-24 03:33:16 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698