Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Unified Diff: build/android/pylib/gtest/test_package.py

Issue 12049046: Revert 178345 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/pylib/gtest/test_package.py
===================================================================
--- build/android/pylib/gtest/test_package.py (revision 178362)
+++ build/android/pylib/gtest/test_package.py (working copy)
@@ -122,6 +122,8 @@
failed_tests = []
crashed_tests = []
timed_out_tests = []
+ overall_fail = False
+ overall_timed_out = False
# Test case statuses.
re_run = re.compile('\[ RUN \] ?(.*)\r\n')
@@ -144,6 +146,7 @@
if found == 1: # re_passed
break
elif found == 2: # re_runner_fail
+ overall_fail = True
break
else: # re_run
if self.dump_debug_info:
@@ -156,6 +159,7 @@
ok_tests += [BaseTestResult(full_test_name, p.before)]
elif found == 2: # re_crash
crashed_tests += [BaseTestResult(full_test_name, p.before)]
+ overall_fail = True
break
else: # re_fail
failed_tests += [BaseTestResult(full_test_name, p.before)]
@@ -165,6 +169,7 @@
except pexpect.TIMEOUT:
logging.error('Test terminated after %d second timeout.',
self.timeout)
+ overall_timed_out = True
if full_test_name:
timed_out_tests += [BaseTestResult(full_test_name, p.before)]
finally:
@@ -175,7 +180,10 @@
logging.critical(
'gtest exit code: %d\npexpect.before: %s\npexpect.after: %s',
ret_code, p.before, p.after)
+ overall_fail = True
# Create TestResults and return
return TestResults.FromRun(ok=ok_tests, failed=failed_tests,
- crashed=crashed_tests, timed_out=timed_out_tests)
+ crashed=crashed_tests, timed_out=timed_out_tests,
+ overall_fail=overall_fail,
+ overall_timed_out=overall_timed_out)
« no previous file with comments | « build/android/pylib/gtest/single_test_runner.py ('k') | build/android/pylib/utils/flakiness_dashboard_results_uploader.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698