runtime/vm/flow_graph_optimizer.cc - Issue 12049039: Fix source position for stack traces with optimized top function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_optimizer.cc

Issue 12049039: Fix source position for stack traces with optimized top function. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: rebase Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_optimizer.cc

===================================================================

--- runtime/vm/flow_graph_optimizer.cc (revision 17754)

+++ runtime/vm/flow_graph_optimizer.cc (working copy)

@@ -690,7 +690,11 @@

type_args,

value_type,

Symbols::Value());

- InsertBefore(call, assert_value, NULL, Definition::kValue);

+ // Newly inserted instructions that can deoptimize or throw an exception

+ // must have a deoptimization id that is valid for lookup in the unoptimized

+ // code.

+ assert_value->deopt_id_ = call->deopt_id();

+ InsertBefore(call, assert_value, call->env(), Definition::kValue);

}

Value* array = NULL;

« no previous file with comments | « runtime/vm/flow_graph_compiler_x64.cc ('k') | runtime/vm/intermediate_language.h » ('j') | no next file with comments »