runtime/vm/exceptions.cc - Issue 12049039: Fix source position for stack traces with optimized top function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/exceptions.cc

Issue 12049039: Fix source position for stack traces with optimized top function. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: rebase Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/exceptions.cc

===================================================================

--- runtime/vm/exceptions.cc (revision 17754)

+++ runtime/vm/exceptions.cc (working copy)

@@ -63,9 +63,10 @@

break;

}

ASSERT(pc != 0);

- code = func.unoptimized_code();

- offset = Smi::New(pc - code.EntryPoint());

if (ShouldShowFunction(func)) {

+ code = func.unoptimized_code();

+ offset = Smi::New(pc - code.EntryPoint());

+ ASSERT(0 <= offset.Value() && offset.Value() < code.Size());

func_list.Add(func);

code_list.Add(code);

pc_offset_list.Add(offset);

« no previous file with comments | « runtime/vm/deopt_instructions.cc ('k') | runtime/vm/flow_graph_compiler.h » ('j') | no next file with comments »