Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(831)

Unified Diff: runtime/vm/exceptions.cc

Issue 12049039: Fix source position for stack traces with optimized top function. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: avoid default arguments by using pending_deoptimization_env_ Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/exceptions.cc
===================================================================
--- runtime/vm/exceptions.cc (revision 17448)
+++ runtime/vm/exceptions.cc (working copy)
@@ -49,12 +49,11 @@
InlinedFunctionsInDartFrameIterator optimized_frames(frame);
while (true) {
uword pc = 0;
- func = optimized_frames.GetNextFunction(&pc);
+ func = optimized_frames.GetNextFunction(&pc, &code);
if (func.IsNull()) {
break;
}
ASSERT(pc != 0);
- code = func.unoptimized_code();
offset = Smi::New(pc - code.EntryPoint());
func_list.Add(func);
code_list.Add(code);

Powered by Google App Engine
This is Rietveld 408576698