Cleanup the namer, and add a test with fields that used to clash with internal names used by the co…

sdk/lib/_internal/compiler/implementation/js_backend/minify_namer.dart

Index: sdk/lib/_internal/compiler/implementation/js_backend/minify_namer.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/js_backend/minify_namer.dart	(revision 17449)
+++ sdk/lib/_internal/compiler/implementation/js_backend/minify_namer.dart	(working copy)
@@ -21,7 +21,9 @@
 
   // You can pass an invalid identifier to this and unlike its non-minifying
   // counterpart it will never return the proposedName as the new fresh name.
-  String getFreshName(String proposedName, Set<String> usedNames) {
+  String getFreshName(String proposedName,
+                      Set<String> usedNames,
+                      bool ensureSafe) {
     var freshName = _getUnusedName(proposedName, usedNames);
     usedNames.add(freshName);
     return freshName;
@@ -35,7 +37,9 @@
   }
 
   void reserveBackendNames() {
-    for (var name in JsNames.reservedNativeProperties) {
+     // TODO(sra): We need a complete list from the DOM.
+    const reservedNativeProperties = const <String>["x", "y", "z"];

[sra1, 2013/01/23 21:23:21]

According to Issue 7554:

Q a b c d e f r x y z
ch cx cy db dx dy fr fx fy go id k1 k2 k3 k4 r1 r2 rx ry x1 x2 y1 y2  

The full list is ~3000 names.

These names are bad only if the object on which they appear can flow to the same
use site as the native object with a property of the same name.

There is no harm in having *fields* with these names since to generate a field
access, the compiler needs to resolve the type of the receiver, which protects
against conflicts.

[ngeoffray, 2013/01/24 10:33:17]

I added the bug reference number to the TODO.

+    for (var name in reservedNativeProperties) {
       if (name.length < 3) {
         instanceNameMap[name] = name;
       }