sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart - Issue 12049036: Cleanup the namer, and add a test with fields that used to clash with internal names used by the co…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart

Issue 12049036: Cleanup the namer, and add a test with fields that used to clash with internal names used by the co… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/js_backend/minify_namer.dart » ('j') | sdk/lib/_internal/compiler/implementation/js_backend/namer.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart

===================================================================

--- sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart (revision 17449)

+++ sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart (working copy)

@@ -479,7 +479,7 @@

// the actual receiver.

int extraArgumentCount = isInterceptorClass ? 1 : 0;

// Use '$receiver' to avoid clashes with other parameter names. Using

- // '$receiver' works because [JsNames.getValid] used for getting parameter

+ // '$receiver' works because [:namer.safeName:] used for getting parameter

// names never returns a name beginning with a single '$'.

String receiverArgumentName = r'$receiver';

@@ -504,7 +504,7 @@

compiler.enqueuer.resolution.getCachedElements(member);

parameters.orderedForEachParameter((Element element) {

- String jsName = JsNames.getValid(element.name.slowToString());

+ String jsName = backend.namer.safeName(element.name.slowToString());

assert(jsName != receiverArgumentName);

int optionalParameterStart = positionalArgumentCount + extraArgumentCount;

if (count < optionalParameterStart) {