test/cctest/testcfg.py - Issue 12049034: tools/run-tests.py: shlex.split() the value of --command-prefix

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/testcfg.py

Issue 12049034: tools/run-tests.py: shlex.split() the value of --command-prefix (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/testcfg.py

diff --git a/test/cctest/testcfg.py b/test/cctest/testcfg.py

index 1d03a845f53d0bd1f8bdb8c81c0e8bc66a74ddfd..7bcccfa2cc6dcc4ffa91367bb253c633a8c08e11 100644

--- a/test/cctest/testcfg.py

+++ b/test/cctest/testcfg.py

@@ -47,10 +47,10 @@ class CcTestSuite(testsuite.TestSuite):

def ListTests(self, context):

shell = os.path.abspath(os.path.join(context.shell_dir, self.shell()))

if utils.IsWindows():

- shell += '.exe'

- output = commands.Execute([context.command_prefix,

- shell,

- '--list',

+ shell += ".exe"

+ output = commands.Execute(context.command_prefix +

+ [shell,

+ "--list",

context.extra_flags])

if output.exit_code != 0:

print output.stdout

« no previous file with comments | « no previous file | tools/run-tests.py » ('j') | no next file with comments »