Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 1204903004: MIPS: [turbofan] Fix implementation of Float64Min. (Closed)

Created:
5 years, 6 months ago by balazs.kilvady
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: [turbofan] Fix implementation of Float64Min. Port d783b763629526a1ec57a9f14caa61d0166efac7 Original commit message: ARM64's `fmin` and `fmax` instructions don't have the same behaviour as TurboFan's Float(32|64)(Min|Max) functions. BUG=4206 LOG=N Committed: https://crrev.com/803b0c7487ecc09197cc8ba1667a5a0f3100a8d8 Cr-Commit-Position: refs/heads/master@{#29305}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -48 lines) Patch
M src/compiler/mips/instruction-selector-mips.cc View 2 chunks +4 lines, -22 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 2 chunks +6 lines, -26 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
balazs.kilvady
5 years, 6 months ago (2015-06-25 11:39:40 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1204903004/1
5 years, 6 months ago (2015-06-25 11:40:01 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-25 12:06:46 UTC) #6
paul.l...
lgtm
5 years, 6 months ago (2015-06-25 17:53:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1204903004/1
5 years, 6 months ago (2015-06-25 17:58:20 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-25 17:59:49 UTC) #11
commit-bot: I haz the power
5 years, 6 months ago (2015-06-25 18:00:01 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/803b0c7487ecc09197cc8ba1667a5a0f3100a8d8
Cr-Commit-Position: refs/heads/master@{#29305}

Powered by Google App Engine
This is Rietveld 408576698