Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Unified Diff: utils/pub/error_group.dart

Issue 12049013: Change singleSubscription/multiSubscription to normal/broadcast. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: utils/pub/error_group.dart
diff --git a/utils/pub/error_group.dart b/utils/pub/error_group.dart
index a9f78617f7be0b9d7e1c5ecee3f4fa568c9ec11e..40f1ad2f7bc056d73546e1ba90532b99fddf2317 100644
--- a/utils/pub/error_group.dart
+++ b/utils/pub/error_group.dart
@@ -233,9 +233,9 @@ class _ErrorGroupStream extends Stream {
/// Creates a new [_ErrorGroupFuture] that's a child of [_group] and wraps
/// [inner].
_ErrorGroupStream(this._group, Stream inner)
- : _controller = inner.isSingleSubscription ?
- new StreamController() :
- new StreamController.multiSubscription() {
+ : _controller = inner.isMulticast ?
floitsch 2013/01/22 14:37:56 isBroadcast?
Lasse Reichstein Nielsen 2013/01/22 15:33:37 Fixed *blush*.
+ new StreamController.multiSubscription() :
floitsch 2013/01/22 14:37:56 Didn't see any change to this, but just to make su
Lasse Reichstein Nielsen 2013/01/22 15:33:37 Ack no, it should be changed too.
+ new StreamController() {
_subscription = inner.listen(_controller.add,
onError: (e) => _group._signalError(e),
onDone: () {

Powered by Google App Engine
This is Rietveld 408576698