Serializer: commit new internalized strings after deserialization.

Serializer: commit new internalized strings after deserialization.

Reserving space for deserialization can cause GC, which
can evict entries from the string table. Having more deleted
entries now, StringTable::EnsureCapacity could cause a GC
later during deserialization even when we actually still
have enough capacity.

Instead, we now keep new internalized strings in a separate list
and commit them to the string table at the end.

R=ulan@chromium.org
BUG=chromium:502085
LOG=N

Committed: https://crrev.com/cf21d22fd8209f11f88b8665e68a24627e3e5161
Cr-Commit-Position: refs/heads/master@{#29308}

[ulan, 2015-06-25 09:49:42]

Looks good. One comment:

https://codereview.chromium.org/1204863006/diff/1/src/snapshot/serialize.cc
File src/snapshot/serialize.cc (right):

https://codereview.chromium.org/1204863006/diff/1/src/snapshot/serialize.cc#n...
src/snapshot/serialize.cc:782: void
Deserializer::NewInternalizedStrings::Commit(Isolate* isolate) {
Please handlify strings before ensuring capacity, otherwise they will be broken.

[Yang, 2015-06-25 10:58:25]

On 2015/06/25 09:49:42, ulan wrote:
> Looks good. One comment:
> 
> https://codereview.chromium.org/1204863006/diff/1/src/snapshot/serialize.cc
> File src/snapshot/serialize.cc (right):
> 
>
https://codereview.chromium.org/1204863006/diff/1/src/snapshot/serialize.cc#n...
> src/snapshot/serialize.cc:782: void
> Deserializer::NewInternalizedStrings::Commit(Isolate* isolate) {
> Please handlify strings before ensuring capacity, otherwise they will be
broken.

please take another look.

[ulan, 2015-06-25 16:26:30]

lgtm

[Yang, 2015-06-25 18:13:03]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2015-06-25 18:13:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1204863006/40001

[commit-bot: I haz the power, 2015-06-25 19:04:31]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-06-25 19:04:44]

Patchset 3 (id:??) landed as
https://crrev.com/cf21d22fd8209f11f88b8665e68a24627e3e5161
Cr-Commit-Position: refs/heads/master@{#29308}