Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(25)

Issue 1204853003: Use EditingTestBase for StyledMarkupSerializerTest (Closed)

Created:
4 years, 10 months ago by hajimehoshi
Modified:
4 years, 10 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, blink-reviews-style_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Use EditingTestBase for StyledMarkupSerializerTest This CL changes StyledMarkupSerializerTest to inherit EditingTestBase to reduce duplicated code. BUG=n/a TEST=n/a; no behavior change Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197795

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -60 lines) Patch
M Source/core/editing/StyledMarkupSerializerTest.cpp View 1 2 chunks +4 lines, -60 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
hajimehoshi
PTAL
4 years, 10 months ago (2015-06-24 09:10:30 UTC) #2
yosin_UTC9
lgtm In description, s/redundant/duplicated/ ?
4 years, 10 months ago (2015-06-24 09:27:38 UTC) #3
hajimehoshi
I found this requires rebasing.
4 years, 10 months ago (2015-06-24 10:15:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1204853003/60001
4 years, 10 months ago (2015-06-25 02:29:17 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2015-06-25 03:42:42 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197795

Powered by Google App Engine
This is Rietveld 408576698