Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 1204843004: Revert of Video Capture: extract storage info from pixel format in VideoCaptureFormat. (Closed)

Created:
5 years, 6 months ago by dcheng
Modified:
5 years, 6 months ago
Reviewers:
mcasas, hubbe, DaleCurtis, miu
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch_chromium.org, miu+watch_chromium.org, posciak+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Video Capture: extract storage info from pixel format in VideoCaptureFormat. (patchset #7 id:290001 of https://codereview.chromium.org/1179323002/) Reason for revert: The IPC changes in this patch were not reviewed. Original issue's description: > Video Capture: extract storage info from pixel format in VideoCaptureFormat. > > Video Capture Devices treat both Texture and GpuMemoryBuffer > as a VideoPixelFormat, but they are storage types. Moreover, > this merging prevents capture devices from indicating a > combination of Storage and Capture formats, i.e. > Texture + ARGB, or GpuMemoryBuffer+YUY2. > > This CL separates both concepts and updates necessary > call points. It also extends the translation > VideoCaptureFormat --> VideoFrame in > VideoCaptureDeviceClient and in VideoCaptureBufferPool. > VideoCaptureBufferPool::ReserveOutputBuffer() > also gets a param to specify the StorageType. > > This separation also allows for VideoCaptureBufferPool > to operate using VideoPixel{Format, Storage} ISO > VideoFrame types, which spares the constant conversion > between ones and others. > > Test: All video captures working exactly as before. > BUG=440843 > > TBR=dcheng@chromium.org for media_param_traits.cc > (Rationale: the change is small and I'm still going to be > actively working in this area so we can follow up in > other reviews). > > Committed: https://crrev.com/957fb245c45052e2c4b2bb0f59e165ba05096904 > Cr-Commit-Position: refs/heads/master@{#335872} TBR=dalecurtis@chromium.org,hubbe@chromium.org,miu@chromium.org,mcasas@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=440843 Committed: https://crrev.com/07cf16152edf2771e8788c1c3745bc287b8206cf Cr-Commit-Position: refs/heads/master@{#335968}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+212 lines, -275 lines) Patch
M content/browser/media/capture/aura_window_capture_machine.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M content/browser/media/capture/desktop_capture_device_aura_unittest.cc View 1 chunk +2 lines, -8 lines 0 comments Download
M content/browser/media/capture/desktop_capture_device_unittest.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M content/browser/media/capture/web_contents_video_capture_device_unittest.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M content/browser/media/media_internals_unittest.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_buffer_pool.h View 4 chunks +8 lines, -10 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_buffer_pool.cc View 9 chunks +67 lines, -23 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_buffer_pool_unittest.cc View 5 chunks +14 lines, -30 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_controller.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_controller_unittest.cc View 12 chunks +25 lines, -34 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_device_client.h View 1 chunk +2 lines, -4 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_device_client.cc View 8 chunks +27 lines, -35 lines 0 comments Download
M content/common/media/media_param_traits.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M media/base/video_capture_types.h View 4 chunks +2 lines, -17 lines 0 comments Download
M media/base/video_capture_types.cc View 5 chunks +16 lines, -37 lines 0 comments Download
M media/capture/screen_capture_device_core.cc View 1 chunk +5 lines, -7 lines 0 comments Download
M media/capture/thread_safe_capture_oracle.cc View 2 chunks +6 lines, -10 lines 0 comments Download
M media/video/capture/fake_video_capture_device.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/video/capture/fake_video_capture_device.cc View 5 chunks +10 lines, -16 lines 0 comments Download
M media/video/capture/fake_video_capture_device_unittest.cc View 1 chunk +4 lines, -7 lines 0 comments Download
M media/video/capture/video_capture_device.h View 1 chunk +2 lines, -3 lines 0 comments Download
M media/video/capture/video_capture_device_unittest.cc View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dcheng
Created Revert of Video Capture: extract storage info from pixel format in VideoCaptureFormat.
5 years, 6 months ago (2015-06-24 19:00:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1204843004/1
5 years, 6 months ago (2015-06-24 19:01:33 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-24 19:07:32 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-24 19:08:34 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/07cf16152edf2771e8788c1c3745bc287b8206cf
Cr-Commit-Position: refs/heads/master@{#335968}

Powered by Google App Engine
This is Rietveld 408576698