DescriptionRevert of Video Capture: extract storage info from pixel format in VideoCaptureFormat. (patchset #7 id:290001 of https://codereview.chromium.org/1179323002/)
Reason for revert:
The IPC changes in this patch were not reviewed.
Original issue's description:
> Video Capture: extract storage info from pixel format in VideoCaptureFormat.
>
> Video Capture Devices treat both Texture and GpuMemoryBuffer
> as a VideoPixelFormat, but they are storage types. Moreover,
> this merging prevents capture devices from indicating a
> combination of Storage and Capture formats, i.e.
> Texture + ARGB, or GpuMemoryBuffer+YUY2.
>
> This CL separates both concepts and updates necessary
> call points. It also extends the translation
> VideoCaptureFormat --> VideoFrame in
> VideoCaptureDeviceClient and in VideoCaptureBufferPool.
> VideoCaptureBufferPool::ReserveOutputBuffer()
> also gets a param to specify the StorageType.
>
> This separation also allows for VideoCaptureBufferPool
> to operate using VideoPixel{Format, Storage} ISO
> VideoFrame types, which spares the constant conversion
> between ones and others.
>
> Test: All video captures working exactly as before.
> BUG=440843
>
> TBR=dcheng@chromium.org for media_param_traits.cc
> (Rationale: the change is small and I'm still going to be
> actively working in this area so we can follow up in
> other reviews).
>
> Committed: https://crrev.com/957fb245c45052e2c4b2bb0f59e165ba05096904
> Cr-Commit-Position: refs/heads/master@{#335872}
TBR=dalecurtis@chromium.org,hubbe@chromium.org,miu@chromium.org,mcasas@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=440843
Committed: https://crrev.com/07cf16152edf2771e8788c1c3745bc287b8206cf
Cr-Commit-Position: refs/heads/master@{#335968}
Patch Set 1 #
Created: 5 years, 6 months ago
(Patch set is too large to download)
Messages
Total messages: 4 (0 generated)
|