Add metrics for Webstore Gallery Widget app

components/chrome_apps/webstore_widget/app/main.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 //<include src="../../../../ui/webui/resources/js/cr.js">
 //<include src="../../../../ui/webui/resources/js/load_time_data.js">
 //<include src="../../../../ui/webui/resources/js/i18n_template_no_process.js">
 //<include src="../../../../ui/webui/resources/js/cr/event_target.js">
 //<include src="../../../../ui/webui/resources/js/cr/ui/dialogs.js">
 
@@ skipping 50 matching lines @@
     strings: {
       UI_LOCALE: getString('language'),
       LINK_TO_WEBSTORE: getString('LINK_TO_WEBSTORE'),
       INSTALLATION_FAILED_MESSAGE: getString('INSTALLATION_FAILED_MESSAGE'),
       LOADING_SPINNER_ALT: getString('LOADING_SPINNER_ALT'),
       INSTALLING_SPINNER_ALT: getString('INSTALLING_SPINNER_ALT')
     },
 
     metricsImpl: {
       /**
+       * Map from interval name to interval start timestamp.
+       * @type {Object<string, Date>}
+       */
+      intervals: {},
+
+      /**
        * @param {string} enumName
        * @param {number} value
        * @param {number} enumSize
        */
-      recordEnum: function(enumName, value, enumSize) {},
+      recordEnum: function(enumName, value, enumSize) {
+        var index = (value >= 0 && value < enumSize) ? value : enumSize - 1;
+        chrome.metricsPrivate.recordValue({
+          'metricName': 'WebstoreWidgetApp.' + enumName,
+          'type': 'histogram-linear',
+          'min': 1,
+          'max': enumSize,
+          'buckets': enumSize

[Ilya Sherman, 2015/06/25 21:40:29]

Hmm, I think that either max should be "enumSize - 1", or buckets should be
"enumSize".  Does the metricsPrivate API not have a method to emit to an
enumerated histogram?  If not, perhaps it's worth adding one, so that we only
need to get this implementation detail right once?

[tbarzic, 2015/06/25 22:31:09]

This is how these values are recorded in File Manager metrics..

The issue is that values in these enums start at 0. To work around this, the
underflow bucket is used as a real bucket (and values that would usually be sent
there are moved to overflow bucket).
So we end up with one bucket less than usual.
Though, maybe I could just set min to 0 and max to enumSize - 1?

[Ilya Sherman, 2015/06/25 22:36:31]

It's fine for the underflow bucket to be emitted to -- that's what most
enumerated histograms do.  But, you still need to leave space for the overflow
bucket.  So, if you're actually emitting to N buckets, and one of those N
buckets is the underflow bucket, then you need N + 1 buckets to be allocated,
where the extra bucket is the overflow bucket.

[tbarzic, 2015/06/25 22:46:12]

Done.

+        }, index);
+      },
 
       /** @param {string} actionName */
-      recordUserAction: function(actionName) {},
+      recordUserAction: function(actionName) {
+        chrome.metricsPrivate.recordUserAction(
+            'WebstoreWidgetApp.' + actionName);

[Ilya Sherman, 2015/06/25 21:40:30]

Please update actions.xml with any actions that you're adding.

[tbarzic, 2015/06/25 22:31:09]

Done.

+      },
 
       /** @param {string} intervalName */
-      startInterval: function(intervalName) {},
+      startInterval: function(intervalName) {
+        this.intervals[intervalName] = Date.now();
+      },
 
       /** @param {string} intervalName */
-      recordInterval: function(intervalName) {}
+      recordInterval: function(intervalName) {
+        if (!intervalName in this.intervals) {
+          console.error('Interval \'' + intervalName + '\' not started');
+          return;
+        }
+
+       chrome.metricsPrivate.recordTime(
+           'WebstoreWidgetApp.' + intervalName,
+           Date.now() - this.intervals[intervalName]);
+        delete this.intervals[intervalName];
+      }
     },
 
     /**
      * @param {string} itemId Item to be installed.
      * @param {function(?string)} callback Callback param is the error message,
      *     which is set to null on success.
      */
     installWebstoreItem: function(itemId, callback) {
       chrome.webstoreWidgetPrivate.installWebstoreItem(
           itemId,
@@ skipping 110 matching lines @@
           var result = widgetContainer.finalizeAndGetResult();
           showWidgetResult(result.result);
         })
         /** @param {*} error */
         .catch(function(error) {
           showWidgetResult(CWSWidgetContainer.Result.FAILED);
         });
   });
 });
 })();