Add metrics for Webstore Gallery Widget app

Add metrics for Webstore Gallery Widget app

The recorded metrics is equivalent to one recorded for File Manager's
Suggest Apps dialog.

BUG=439448
TEST=None

Committed: https://crrev.com/d1273fc0d0b9cec7f9f813b706583731ef61f1a9
Cr-Commit-Position: refs/heads/master@{#336404}

[tbarzic, 2015-06-25 06:16:39]

tbarzic@chromium.org changed reviewers:
+ yoshiki@chromium.org

[tbarzic, 2015-06-25 18:14:19]

tbarzic@chromium.org changed reviewers:
+ isherman@chromium.org

[Ilya Sherman, 2015-06-25 21:40:30]

https://codereview.chromium.org/1204783007/diff/20001/components/chrome_apps/...
File components/chrome_apps/webstore_widget/app/main.js (right):

https://codereview.chromium.org/1204783007/diff/20001/components/chrome_apps/...
components/chrome_apps/webstore_widget/app/main.js:88: 'buckets': enumSize
Hmm, I think that either max should be "enumSize - 1", or buckets should be
"enumSize".  Does the metricsPrivate API not have a method to emit to an
enumerated histogram?  If not, perhaps it's worth adding one, so that we only
need to get this implementation detail right once?

https://codereview.chromium.org/1204783007/diff/20001/components/chrome_apps/...
components/chrome_apps/webstore_widget/app/main.js:95: 'WebstoreWidgetApp.' +
actionName);
Please update actions.xml with any actions that you're adding.

https://codereview.chromium.org/1204783007/diff/20001/components/chrome_apps/...
File components/chrome_apps/webstore_widget/cws_widget/cws_widget_container.js
(right):

https://codereview.chromium.org/1204783007/diff/20001/components/chrome_apps/...
components/chrome_apps/webstore_widget/cws_widget/cws_widget_container.js:926:
this.metricsImpl_.recordEnum('Load', result, 3);
Hmm, why did you change this code?

https://codereview.chromium.org/1204783007/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1204783007/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:49049: +    between the moment window
appears and the moment all the contants in the app
nit: "contants" -> "contents"

[tbarzic, 2015-06-25 22:31:09]

https://codereview.chromium.org/1204783007/diff/20001/components/chrome_apps/...
File components/chrome_apps/webstore_widget/app/main.js (right):

https://codereview.chromium.org/1204783007/diff/20001/components/chrome_apps/...
components/chrome_apps/webstore_widget/app/main.js:88: 'buckets': enumSize
On 2015/06/25 21:40:29, Ilya Sherman wrote:
> Hmm, I think that either max should be "enumSize - 1", or buckets should be
> "enumSize".  Does the metricsPrivate API not have a method to emit to an
> enumerated histogram?  If not, perhaps it's worth adding one, so that we only
> need to get this implementation detail right once?

This is how these values are recorded in File Manager metrics..

The issue is that values in these enums start at 0. To work around this, the
underflow bucket is used as a real bucket (and values that would usually be sent
there are moved to overflow bucket).
So we end up with one bucket less than usual.
Though, maybe I could just set min to 0 and max to enumSize - 1?

https://codereview.chromium.org/1204783007/diff/20001/components/chrome_apps/...
components/chrome_apps/webstore_widget/app/main.js:95: 'WebstoreWidgetApp.' +
actionName);
On 2015/06/25 21:40:30, Ilya Sherman wrote:
> Please update actions.xml with any actions that you're adding.

Done.

https://codereview.chromium.org/1204783007/diff/20001/components/chrome_apps/...
File components/chrome_apps/webstore_widget/cws_widget/cws_widget_container.js
(right):

https://codereview.chromium.org/1204783007/diff/20001/components/chrome_apps/...
components/chrome_apps/webstore_widget/cws_widget/cws_widget_container.js:926:
this.metricsImpl_.recordEnum('Load', result, 3);
On 2015/06/25 21:40:30, Ilya Sherman wrote:
> Hmm, why did you change this code?

This is used by File Manager app and Webstore Widget app (this cl adds metrics
for the latter one)

I moved appending SuggestApps. into file_manager code (the file manager app
records FileBrowser.SugestApps.Load) metric, since SuggestApps doesn't really
belong here (it's how File Manager code refers to the dialog showing the control
defined here)

https://codereview.chromium.org/1204783007/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1204783007/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:49049: +    between the moment window
appears and the moment all the contants in the app
On 2015/06/25 21:40:30, Ilya Sherman wrote:
> nit: "contants" -> "contents"

Done.

[Ilya Sherman, 2015-06-25 22:36:32]

https://codereview.chromium.org/1204783007/diff/20001/components/chrome_apps/...
File components/chrome_apps/webstore_widget/app/main.js (right):

https://codereview.chromium.org/1204783007/diff/20001/components/chrome_apps/...
components/chrome_apps/webstore_widget/app/main.js:88: 'buckets': enumSize
On 2015/06/25 22:31:09, tbarzic wrote:
> On 2015/06/25 21:40:29, Ilya Sherman wrote:
> > Hmm, I think that either max should be "enumSize - 1", or buckets should be
> > "enumSize".  Does the metricsPrivate API not have a method to emit to an
> > enumerated histogram?  If not, perhaps it's worth adding one, so that we
only
> > need to get this implementation detail right once?
> 
> This is how these values are recorded in File Manager metrics..
> 
> The issue is that values in these enums start at 0. To work around this, the
> underflow bucket is used as a real bucket (and values that would usually be
sent
> there are moved to overflow bucket).
> So we end up with one bucket less than usual.
> Though, maybe I could just set min to 0 and max to enumSize - 1?

It's fine for the underflow bucket to be emitted to -- that's what most
enumerated histograms do.  But, you still need to leave space for the overflow
bucket.  So, if you're actually emitting to N buckets, and one of those N
buckets is the underflow bucket, then you need N + 1 buckets to be allocated,
where the extra bucket is the overflow bucket.

https://codereview.chromium.org/1204783007/diff/20001/components/chrome_apps/...
File components/chrome_apps/webstore_widget/cws_widget/cws_widget_container.js
(right):

https://codereview.chromium.org/1204783007/diff/20001/components/chrome_apps/...
components/chrome_apps/webstore_widget/cws_widget/cws_widget_container.js:926:
this.metricsImpl_.recordEnum('Load', result, 3);
On 2015/06/25 22:31:09, tbarzic wrote:
> On 2015/06/25 21:40:30, Ilya Sherman wrote:
> > Hmm, why did you change this code?
> 
> This is used by File Manager app and Webstore Widget app (this cl adds metrics
> for the latter one)
> 
> I moved appending SuggestApps. into file_manager code (the file manager app
> records FileBrowser.SugestApps.Load) metric, since SuggestApps doesn't really
> belong here (it's how File Manager code refers to the dialog showing the
control
> defined here)

I see.  I think I understand now what the code used to be doing.  Okay, thanks
for the explanation.

https://codereview.chromium.org/1204783007/diff/40001/tools/metrics/actions/a...
File tools/metrics/actions/actions.xml (right):

https://codereview.chromium.org/1204783007/diff/40001/tools/metrics/actions/a...
tools/metrics/actions/actions.xml:12335: <description>Please enter the
description of this user action.</description>
^^^

[tbarzic, 2015-06-25 22:46:12]

https://codereview.chromium.org/1204783007/diff/20001/components/chrome_apps/...
File components/chrome_apps/webstore_widget/app/main.js (right):

https://codereview.chromium.org/1204783007/diff/20001/components/chrome_apps/...
components/chrome_apps/webstore_widget/app/main.js:88: 'buckets': enumSize
On 2015/06/25 22:36:31, Ilya Sherman wrote:
> On 2015/06/25 22:31:09, tbarzic wrote:
> > On 2015/06/25 21:40:29, Ilya Sherman wrote:
> > > Hmm, I think that either max should be "enumSize - 1", or buckets should
be
> > > "enumSize".  Does the metricsPrivate API not have a method to emit to an
> > > enumerated histogram?  If not, perhaps it's worth adding one, so that we
> only
> > > need to get this implementation detail right once?
> > 
> > This is how these values are recorded in File Manager metrics..
> > 
> > The issue is that values in these enums start at 0. To work around this, the
> > underflow bucket is used as a real bucket (and values that would usually be
> sent
> > there are moved to overflow bucket).
> > So we end up with one bucket less than usual.
> > Though, maybe I could just set min to 0 and max to enumSize - 1?
> 
> It's fine for the underflow bucket to be emitted to -- that's what most
> enumerated histograms do.  But, you still need to leave space for the overflow
> bucket.  So, if you're actually emitting to N buckets, and one of those N
> buckets is the underflow bucket, then you need N + 1 buckets to be allocated,
> where the extra bucket is the overflow bucket.

Done.

https://codereview.chromium.org/1204783007/diff/40001/tools/metrics/actions/a...
File tools/metrics/actions/actions.xml (right):

https://codereview.chromium.org/1204783007/diff/40001/tools/metrics/actions/a...
tools/metrics/actions/actions.xml:12335: <description>Please enter the
description of this user action.</description>
On 2015/06/25 22:36:32, Ilya Sherman wrote:
> ^^^

Done.

[yoshiki, 2015-06-26 02:22:00]

lgtm

[Ilya Sherman, 2015-06-26 04:42:22]

LGTM

[tbarzic, 2015-06-26 16:27:11]

The CQ bit was checked by tbarzic@chromium.org

[commit-bot: I haz the power, 2015-06-26 16:27:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1204783007/60001

[commit-bot: I haz the power, 2015-06-26 17:55:29]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-06-26 17:57:23]

Patchset 4 (id:??) landed as
https://crrev.com/d1273fc0d0b9cec7f9f813b706583731ef61f1a9
Cr-Commit-Position: refs/heads/master@{#336404}