Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(49)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1204783002: Fix glyph overflow with word-spacing (Closed)

Created:
4 years, 10 months ago by Xianzhu
Modified:
4 years, 10 months ago
Reviewers:
chrishtr, eae
CC:
blink-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, blink-reviews-rendering, jchaffraix+rendering
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix glyph overflow with word-spacing Word-spacing is included in the width of WordMeasurement, so WordMeasurement.glyphBounds should be relative to start of the word which is before the word spacing. BUG=496317 TEST=fast/text/glyph-overflow-with-word-spacing.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197679

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
A LayoutTests/fast/text/glyph-overflow-with-word-spacing.html View 1 chunk +6 lines, -0 lines 0 comments Download
A LayoutTests/fast/text/glyph-overflow-with-word-spacing-expected.html View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/layout/line/BreakingContextInlineHeaders.h View 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Xianzhu
4 years, 10 months ago (2015-06-23 20:37:48 UTC) #2
eae
LGTM
4 years, 10 months ago (2015-06-23 20:40:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1204783002/1
4 years, 10 months ago (2015-06-23 21:56:17 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2015-06-23 22:51:24 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197679

Powered by Google App Engine
This is Rietveld 408576698