tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 93fbf671ef5846458af10e83e452f9fafe20354b..9d7c9eae511ad7f5b35c1a480f500461a0dccf6a 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -4495,6 +4495,16 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   </summary>
 </histogram>
 
+<histogram name="CustomTabs.ClientAppId" enum="ClientAppId">
+  <owner>yusufo@chromium.org</owner>
+  <summary>
+    Android: AppId declared by the launching application in EXTRA_APPLICATION_ID
+    in a custom tab. This histogram is used as a means to count the total
+    instances of custom tabs created meanwhile binning them across launching
+    apps that have identified themselves.
+  </summary>
+</histogram>
+
 <histogram name="CustomTabs.IntentToFirstCommitNavigationTime" units="ms">
   <owner>lizeb@chromium.org</owner>
   <summary>
@@ -17243,6 +17253,36 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   </summary>
 </histogram>
 
+<histogram name="MobileStartup.ToolbarFirstDrawTime.ChromeTabbedActivity"
+    units="milliseconds">
+  <owner>yusufo@chromium.org</owner>
+  <summary>
+    Android: The time it takes from launch to the completion of first draw for
+    Toolbar in TABBED mode. This excludes activity creation time spent in
+    framework.
+  </summary>
+</histogram>

[Ilya Sherman, 2015/06/23 22:57:42]

Optional: You might want to use a histogram_suffixes element to reduce
redundancy.

[Yusuf, 2015/06/23 23:14:16]

Done.

+
+<histogram name="MobileStartup.ToolbarFirstDrawTime.CustomTabActivity"
+    units="milliseconds">
+  <owner>yusufo@chromium.org</owner>
+  <summary>
+    Android: The time it takes from launch to the completion of first draw for
+    Toolbar in a CUSTOM TAB. This excludes activity creation time spent in
+    framework.
+  </summary>
+</histogram>
+
+<histogram name="MobileStartup.ToolbarFirstDrawTime.DocumentActivity"
+    units="milliseconds">
+  <owner>yusufo@chromium.org</owner>
+  <summary>
+    Android: The time it takes from launch to the completion of first draw for
+    Toolbar in DOCUMENT mode(Tabs and apps together). This excludes activity

[Ilya Sherman, 2015/06/23 22:57:42]

nit: "mode(" -> "mode ("

[Yusuf, 2015/06/23 23:14:17]

Done.

+    creation time spent in framework.
+  </summary>
+</histogram>
+
 <histogram name="ModuleIntegrityVerification.BytesModified" units="bytes">
   <owner>anthonyvd@chromium.org</owner>
   <summary>
@@ -50947,6 +50987,21 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   <int value="2" label="Fixed Address Load Not Attempted"/>
 </enum>
 
+<enum name="ClientAppId" type="int">
+  <int value="0" label="OTHER"/>

[Ilya Sherman, 2015/06/23 22:57:42]

Is it worth distinguishing "other, identified" from "other, unidentified"
(assuming the latter is possible)?

[Yusuf, 2015/06/23 23:14:17]

Not really since this is mainly declared by the app itself and we don't do much
on our end about guessing. Other here means the app did not specify hence is
unidentified.

[Ilya Sherman, 2015/06/23 23:42:35]

What is recorded if, say, Flipboard, decided to implement this, and identified
itself as "Flipboard"?  Is it the same as what would be recorded if Flipboard
didn't both to identify itself at all?

[Yusuf, 2015/06/24 19:42:24]

Yes, right now it is the same. The spec says they are supposed to include their
package name in this if they choose to do so. And we have to do the bookkeeping
for the apps that include this. If a new one comes along we record as other.

I think changing this to separate the two cases would be useful in identifying
the volume of traffic that is not currently included but can be included with an
update. But not really easy to scale.

+  <int value="1" label="GMAIL"/>
+  <int value="2" label="FACEBOOK"/>
+  <int value="3" label="PLUS"/>
+  <int value="4" label="TWITTER"/>
+  <int value="5" label="CHROME"/>
+  <int value="6" label="HANGOUTS"/>
+  <int value="7" label="MESSENGER"/>
+  <int value="8" label="NEWS"/>
+  <int value="9" label="LINE"/>
+  <int value="10" label="WHATSAPP"/>
+  <int value="11" label="GSA"/>

[Ilya Sherman, 2015/06/23 22:57:42]

Optional nit: I'd suggest using Sentence case, i.e. "Other", "Gmail", etc.

[Yusuf, 2015/06/23 23:14:16]

Done.

+</enum>
+
 <enum name="ClipboardAction" type="int">
   <int value="0" label="Write from non-Incognito"/>
   <int value="1" label="Write from Incognito"/>